From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master ed8b4e0: Prevent running vc-tests writing to ~/.bzr.log Date: Tue, 23 May 2017 00:02:50 +0300 Message-ID: References: <20170521000028.30429.38577@vcs0.savannah.gnu.org> <20170521000029.791B421038@vcs0.savannah.gnu.org> <1b6ac3cf-fe0c-c1cf-5417-e7b3d5231d58@yandex.ru> <8337byp8nc.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1495486987 32286 195.159.176.226 (22 May 2017 21:03:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 May 2017 21:03:07 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 Cc: emacs-devel@gnu.org To: Glenn Morris , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 22 23:03:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCuTn-0008GL-DK for ged-emacs-devel@m.gmane.org; Mon, 22 May 2017 23:03:03 +0200 Original-Received: from localhost ([::1]:44876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCuTs-0006CT-QO for ged-emacs-devel@m.gmane.org; Mon, 22 May 2017 17:03:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCuTj-0006C9-9Z for emacs-devel@gnu.org; Mon, 22 May 2017 17:03:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCuTg-0005PP-7b for emacs-devel@gnu.org; Mon, 22 May 2017 17:02:59 -0400 Original-Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:34896) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCuTg-0005PK-1s; Mon, 22 May 2017 17:02:56 -0400 Original-Received: by mail-wr0-x243.google.com with SMTP id j27so1708592wre.2; Mon, 22 May 2017 14:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f6wRQXbpEk9d5yGf4wljhj/87Cm/8PEvjbfqt5wBolg=; b=KTIyNY4dNiB8z8w7Jow7lcfsVv3GSBR3fU9dbnYKamgltYNm0X4yjjJHB8s/5+oZA4 RAg84ZH+Nsk+dc4OV3GxR9hWxF1T5VVSlyyvfheBF08ZFYMWmACuqPjyIZ/N3JZ6YJDE 2p3JfSp4JOWFcl5OkItyRRAyt+ej/etyeNPvx8xQyBF+uPKQOzMd0k/UXEb6NIAy7CAq 1K+qpV9wprHywmeYc8ZXDE5fTF2wcZ5cLR55mYOBnjn75T8bvcFibX216qfllrNWiuhx CVfMzv5A/PSFrnO8xKmaw0Yw5fKZ+GBBSn23CwtatyWtMGY//vi5/qLCirJIohJ2zmqU /eOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f6wRQXbpEk9d5yGf4wljhj/87Cm/8PEvjbfqt5wBolg=; b=JGXGAyobPhz8akTAD/zlX2EdJrVXfJmcbzw8cwFNBlJppqsaTVHttHPW5fzWVUYjFf SnQgko+pmPGgI6LrsPIwwo2sG3HewTE2w7AyrplkvUPDUJpwrKeTHwePQME9ydl3Kn0J 40c/5p8fOvnuT3IhRBVFlaqT9LH/AWBUDre6UHStIlT/5NJiziND27fEibitPZJ3fhZu o2TzSeZbVzNS12JE2iJGa1DjlJ9Het698UKFQN5FCnIlmhIF9cRyCIQWn9kcpPFH+kHa vxkLGxjo3JyamhI+HbCFEt2+h3FGpSATPrfLlmjhuixzkfaany2IA077nG9BNrC91Wtj ZICg== X-Gm-Message-State: AODbwcDvtkwA2bFlRriUqQhoqSts963+zBg5QWGCkt75/+iUn/0gIzP2 uwOOofDau4Ke4EwlztI= X-Received: by 10.223.177.215 with SMTP id r23mr15008880wra.97.1495486974673; Mon, 22 May 2017 14:02:54 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id a197sm15669290wma.1.2017.05.22.14.02.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 14:02:53 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215110 Archived-At: On 5/22/17 11:52 PM, Glenn Morris wrote: > >>> This is one big patch. > > I don't think adding the same 7 lines to 4 functions is big, > nor something that should be split into more than one commit. Rather, it's a chance that might be hard to maintain. I can easily see myself adding a test or two and forgetting to use Bzr the way you want here. So I have to wonder whether this change is really necessary, or if it could be made in a more fool-proof way. > I think running tests should not interact with HOME at all, > and certainly should not write there. > (Perhaps test/Makefile should export a temporary HOME, > but tests can still be run not via the Makefile.) Perhaps the tests could use a special proxy script for calling Bzr that would reside in the test directory, which disables logging somehow.