From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, rms@gnu.org, tino.calancha@gmail.com
Subject: Re: Why does make run git?
Date: Wed, 2 Aug 2017 13:04:36 -0700 [thread overview]
Message-ID: <f7094b9e-69e6-4673-f3e0-aab83645e12e@cs.ucla.edu> (raw)
In-Reply-To: <8360e5zsxv.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
On 08/02/2017 12:10 PM, Eli Zaretskii wrote:
> Maybe I'm confused, but top-level Makefile.in has this:
>
> $(srcdir)/configure: $(srcdir)/configure.ac $(srcdir)/m4/*.m4
> cd $(srcdir) && ./autogen.sh
>
Ah, you're right, that should say './autogen.sh autoconf', not plain
'./autogen.sh', since the intent is only to build 'configure'. This is a
typo regardless of whether my recently-proposed patch is accepted, and I
fixed it with the attached.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Clarify-when-autogen.sh-should-run-only-autoconf.patch --]
[-- Type: text/x-patch; name="0001-Clarify-when-autogen.sh-should-run-only-autoconf.patch", Size: 1240 bytes --]
From 8aed1e9d1b7a4969039844163f6a89eee78510a9 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 2 Aug 2017 13:01:58 -0700
Subject: [PATCH] Clarify when autogen.sh should run only autoconf
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* Makefile.in (configure, bootstrap): Run ‘./autogen.sh autoconf’,
not plain ‘./autogen.sh’, to make it clear that only
autoconf-related tools should be run here.
---
Makefile.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.in b/Makefile.in
index a31d416bd7..8a08465c4a 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -448,7 +448,7 @@ config.status:
fi
$(srcdir)/configure: $(srcdir)/configure.ac $(srcdir)/m4/*.m4
- cd $(srcdir) && ./autogen.sh
+ cd $(srcdir) && ./autogen.sh autoconf
# ==================== Installation ====================
@@ -1094,7 +1094,7 @@ .PHONY:
# * Rebuild Makefile, to update the build procedure itself.
# * Do the actual build.
bootstrap: bootstrap-clean
- cd $(srcdir) && ./autogen.sh
+ cd $(srcdir) && ./autogen.sh autoconf
$(MAKE) MAKEFILE_NAME=force-Makefile force-Makefile
$(MAKE) all
--
2.13.3
next prev parent reply other threads:[~2017-08-02 20:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 1:19 Why does make run git? Richard Stallman
2017-08-01 3:07 ` Eli Zaretskii
2017-08-01 14:30 ` Richard Stallman
2017-08-01 14:49 ` Tino Calancha
2017-08-02 17:26 ` Richard Stallman
2017-08-02 17:43 ` Radon Rosborough
2017-08-03 19:43 ` Richard Stallman
2017-08-03 20:02 ` Radon Rosborough
2017-08-02 17:56 ` Paul Eggert
2017-08-02 18:31 ` Eli Zaretskii
2017-08-02 18:42 ` Paul Eggert
2017-08-02 19:10 ` Eli Zaretskii
2017-08-02 20:04 ` Paul Eggert [this message]
2017-08-12 16:11 ` Paul Eggert
2017-08-15 14:18 ` Ted Zlatanov
2017-08-15 15:52 ` Paul Eggert
2017-08-15 16:58 ` Ted Zlatanov
2017-08-15 17:08 ` Eli Zaretskii
2017-08-15 20:39 ` Paul Eggert
2017-08-16 12:30 ` Andy Moreton
2017-08-16 12:38 ` Noam Postavsky
2017-08-16 12:49 ` Andreas Schwab
2017-08-16 14:09 ` Ted Zlatanov
2017-08-01 3:14 ` Tino Calancha
2017-08-02 17:25 ` Richard Stallman
2017-08-01 15:10 ` Paul Eggert
2017-08-01 15:15 ` Kaushal Modi
2017-08-01 16:01 ` Radon Rosborough
2017-08-02 17:30 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7094b9e-69e6-4673-f3e0-aab83645e12e@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.