From: "Clément Pit--Claudel" <clement.pit@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, npostavs@users.sourceforge.net
Cc: 25025@debbugs.gnu.org
Subject: bug#25025: python-shell-calculate-command is wrong
Date: Fri, 2 Dec 2016 11:15:16 -0500 [thread overview]
Message-ID: <f6cdddb2-b60d-59ee-8f6d-53526a4b3ca0@gmail.com> (raw)
In-Reply-To: <83k2biokad.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 2183 bytes --]
On 2016-12-02 02:35, Eli Zaretskii wrote:
> Isn't combine-and-quote-strings wrong for quoting shell commands?
> AFAIR, it doesn't DTRT with some special characters that can appear in
> file names on Unix. Am I mistaken?
>
> But if my fears are unjustified, sure, why not? Clément, WDYT?
On 2016-12-02 10:07, npostavs@users.sourceforge.net wrote:
> Okay, let me rephrase. `python-shell-calculate-command' currently
> generates a shell command, but none of its callers treat the result as a
> shell command (they don't pass it to a shell, they parse it with
> `split-string-and-unquote'). Therefore, the easiest fix is to change
> `python-shell-calculate-command' to no longer generate a shell command.
>
> The other possiblity is to change the callers to treat
> `python-shell-calculate-command's result as a shell command, but that
> looks more difficult (though it may be the better solution overall).
Currently, run-python can read a shell command; do we want to remove this feature? If not, then we do need a shell, don't we?
As far as I understand we have two conflicting requirements:
* One part of the code wants access to switches passed to python, as a list of switches.
* One part of the code wants to read a python command, including switches, from the user.
I'm not sure that we can get these two to both work in all cases, unless we come up with a robust way to parse shell commands given by the user. I see multiple solutions:
1. Use a shell to run python. Then the part of the code that wants to know which switches are being passed can use the possibly-incorrect split-string-and-unquote to split user-supplied strings, but the user-supplied command is run as-is through a shell.
2. Keep running python as a subprocess, without a shell; in that case, user-supplied commands (in C-u M-x run-python) need to be "parsed" back into command + switches before running them, which introduces a small potential for incorrect parsing.
Noam, your approach is (2), right? I like the simplicity.
In the long run, it would be nice to offer a read-shell-command-as-list function, probably based on eshell.
Cheers,
Clément.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-12-02 16:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 6:24 bug#25025: python-shell-calculate-command is wrong Fabrice Popineau
2016-11-25 7:03 ` Clément Pit--Claudel
2016-11-25 8:32 ` Eli Zaretskii
2016-11-25 14:44 ` Clément Pit--Claudel
2016-11-25 14:59 ` Noam Postavsky
2016-11-26 18:43 ` Eli Zaretskii
2016-11-27 0:50 ` Noam Postavsky
2016-11-27 2:35 ` Clément Pit--Claudel
2016-11-27 15:56 ` Eli Zaretskii
2016-11-27 16:06 ` npostavs
2016-11-27 16:12 ` Eli Zaretskii
2016-11-28 8:42 ` Andreas Röhler
2016-11-28 14:15 ` npostavs
2016-11-28 16:43 ` Andreas Röhler
2016-11-30 0:39 ` npostavs
2016-11-30 6:39 ` Andreas Röhler
2016-11-30 17:12 ` Clément Pit--Claudel
2016-11-30 0:36 ` npostavs
2016-11-30 1:35 ` Clément Pit--Claudel
2016-11-30 1:56 ` npostavs
2016-11-30 15:55 ` Eli Zaretskii
2016-11-30 22:10 ` Noam Postavsky
2016-12-01 17:10 ` Eli Zaretskii
2016-12-02 1:12 ` npostavs
2016-12-02 7:35 ` Eli Zaretskii
2016-12-02 14:16 ` Noam Postavsky
2016-12-02 14:51 ` Eli Zaretskii
2016-12-02 15:07 ` npostavs
2016-12-02 15:46 ` Eli Zaretskii
2016-12-02 16:15 ` Clément Pit--Claudel [this message]
2016-12-02 16:41 ` Noam Postavsky
2016-12-02 16:58 ` Clément Pit--Claudel
2016-12-09 5:29 ` npostavs
2017-08-16 11:08 ` npostavs
2017-08-16 14:32 ` Eli Zaretskii
2017-08-16 16:50 ` Noam Postavsky
2017-08-16 16:57 ` Eli Zaretskii
2017-08-16 19:27 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6cdddb2-b60d-59ee-8f6d-53526a4b3ca0@gmail.com \
--to=clement.pit@gmail.com \
--cc=25025@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.