From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Master broken by commit b76389f Date: Fri, 8 Jun 2018 08:23:19 -0700 Organization: UCLA Computer Science Department Message-ID: References: <83in6tvc9z.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------263305D0EA556841C22D45BE" X-Trace: blaine.gmane.org 1528471339 21189 195.159.176.226 (8 Jun 2018 15:22:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Jun 2018 15:22:19 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 08 17:22:15 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRJDQ-0005Ho-7M for ged-emacs-devel@m.gmane.org; Fri, 08 Jun 2018 17:22:12 +0200 Original-Received: from localhost ([::1]:36551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRJFX-0006zf-5b for ged-emacs-devel@m.gmane.org; Fri, 08 Jun 2018 11:24:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRJEj-0006zV-D8 for emacs-devel@gnu.org; Fri, 08 Jun 2018 11:23:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRJEi-00057C-5s for emacs-devel@gnu.org; Fri, 08 Jun 2018 11:23:33 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45106) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fRJEe-00053b-6h; Fri, 08 Jun 2018 11:23:28 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4DEFD16066D; Fri, 8 Jun 2018 08:23:26 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id nvNgm_vKEc1z; Fri, 8 Jun 2018 08:23:25 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 22D0E1606C1; Fri, 8 Jun 2018 08:23:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 48gdVKu7_-Oc; Fri, 8 Jun 2018 08:23:25 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D46E116066D; Fri, 8 Jun 2018 08:23:24 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <83in6tvc9z.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226125 Archived-At: This is a multi-part message in MIME format. --------------263305D0EA556841C22D45BE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Thanks for checking that; I fixed it (at least on Fedora i686 --with-wide= -int)=20 by installing the attached patch into master. I'll check the same platfor= m on=20 the Bug#31750 proposed patches before installing them, as these patches a= re=20 doing related (but more-significant) changes to stack and heap allocation= in the=20 Emacs Lisp interpreter. --------------263305D0EA556841C22D45BE Content-Type: text/x-patch; name="0001-Port-alignment-verification-to-x86-with-wide-int.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-Port-alignment-verification-to-x86-with-wide-int.patch" =46rom db353b8649cdae54146308e4c875e53d02b0aaee Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 8 Jun 2018 08:08:03 -0700 Subject: [PATCH] Port alignment verification to x86 --with-wide-int Problem reported by Eli Zaretskii in: https://lists.gnu.org/r/emacs-devel/2018-06/msg00238.html * src/lisp.h (struct Lisp_Symbol, union vectorlike_header) (struct Lisp_Cons, struct Lisp_String): Do not check alignment if !USE_LSB_TAG, as alignment is needed only if we are tagging the low-order bits. --- src/lisp.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lisp.h b/src/lisp.h index 10012b2..293cf27 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -785,7 +785,7 @@ struct Lisp_Symbol GCALIGNED_UNION } u; }; -verify (alignof (struct Lisp_Symbol) % GCALIGNMENT =3D=3D 0); +verify (!USE_LSB_TAG || alignof (struct Lisp_Symbol) % GCALIGNMENT =3D=3D= 0); =20 /* Declare a Lisp-callable function. The MAXARGS parameter has the same= meaning as in the DEFUN macro, and is used to construct a prototype. = */ @@ -898,7 +898,7 @@ union vectorlike_header ptrdiff_t size; GCALIGNED_UNION }; -verify (alignof (union vectorlike_header) % GCALIGNMENT =3D=3D 0); +verify (!USE_LSB_TAG || alignof (union vectorlike_header) % GCALIGNMENT = =3D=3D 0); =20 INLINE bool (SYMBOLP) (Lisp_Object x) @@ -1259,7 +1259,7 @@ struct Lisp_Cons GCALIGNED_UNION } u; }; -verify (alignof (struct Lisp_Cons) % GCALIGNMENT =3D=3D 0); +verify (!USE_LSB_TAG || alignof (struct Lisp_Cons) % GCALIGNMENT =3D=3D = 0); =20 INLINE bool (NILP) (Lisp_Object x) @@ -1381,7 +1381,7 @@ struct Lisp_String GCALIGNED_UNION } u; }; -verify (alignof (struct Lisp_String) % GCALIGNMENT =3D=3D 0); +verify (!USE_LSB_TAG || alignof (struct Lisp_String) % GCALIGNMENT =3D=3D= 0); =20 INLINE bool STRINGP (Lisp_Object x) --=20 2.7.4 --------------263305D0EA556841C22D45BE--