From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Master broken by commit b76389f
Date: Fri, 8 Jun 2018 08:23:19 -0700 [thread overview]
Message-ID: <f6216594-a62e-dbec-f78b-f3d0b63cf956@cs.ucla.edu> (raw)
In-Reply-To: <83in6tvc9z.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
Thanks for checking that; I fixed it (at least on Fedora i686 --with-wide-int)
by installing the attached patch into master. I'll check the same platform on
the Bug#31750 proposed patches before installing them, as these patches are
doing related (but more-significant) changes to stack and heap allocation in the
Emacs Lisp interpreter.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Port-alignment-verification-to-x86-with-wide-int.patch --]
[-- Type: text/x-patch; name="0001-Port-alignment-verification-to-x86-with-wide-int.patch", Size: 1892 bytes --]
From db353b8649cdae54146308e4c875e53d02b0aaee Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 8 Jun 2018 08:08:03 -0700
Subject: [PATCH] Port alignment verification to x86 --with-wide-int
Problem reported by Eli Zaretskii in:
https://lists.gnu.org/r/emacs-devel/2018-06/msg00238.html
* src/lisp.h (struct Lisp_Symbol, union vectorlike_header)
(struct Lisp_Cons, struct Lisp_String):
Do not check alignment if !USE_LSB_TAG, as alignment is
needed only if we are tagging the low-order bits.
---
src/lisp.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/lisp.h b/src/lisp.h
index 10012b2..293cf27 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -785,7 +785,7 @@ struct Lisp_Symbol
GCALIGNED_UNION
} u;
};
-verify (alignof (struct Lisp_Symbol) % GCALIGNMENT == 0);
+verify (!USE_LSB_TAG || alignof (struct Lisp_Symbol) % GCALIGNMENT == 0);
/* Declare a Lisp-callable function. The MAXARGS parameter has the same
meaning as in the DEFUN macro, and is used to construct a prototype. */
@@ -898,7 +898,7 @@ union vectorlike_header
ptrdiff_t size;
GCALIGNED_UNION
};
-verify (alignof (union vectorlike_header) % GCALIGNMENT == 0);
+verify (!USE_LSB_TAG || alignof (union vectorlike_header) % GCALIGNMENT == 0);
INLINE bool
(SYMBOLP) (Lisp_Object x)
@@ -1259,7 +1259,7 @@ struct Lisp_Cons
GCALIGNED_UNION
} u;
};
-verify (alignof (struct Lisp_Cons) % GCALIGNMENT == 0);
+verify (!USE_LSB_TAG || alignof (struct Lisp_Cons) % GCALIGNMENT == 0);
INLINE bool
(NILP) (Lisp_Object x)
@@ -1381,7 +1381,7 @@ struct Lisp_String
GCALIGNED_UNION
} u;
};
-verify (alignof (struct Lisp_String) % GCALIGNMENT == 0);
+verify (!USE_LSB_TAG || alignof (struct Lisp_String) % GCALIGNMENT == 0);
INLINE bool
STRINGP (Lisp_Object x)
--
2.7.4
next prev parent reply other threads:[~2018-06-08 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 9:49 Master broken by commit b76389f Eli Zaretskii
2018-06-08 10:01 ` Eli Zaretskii
2018-06-08 15:23 ` Paul Eggert [this message]
2018-06-08 18:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6216594-a62e-dbec-f78b-f3d0b63cf956@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.