From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15746: 24.3; [PATCH] bookmark should confirm when overwrite Date: Tue, 29 Oct 2013 13:09:24 -0700 (PDT) Message-ID: References: <87iowg9bqw.fsf@floss.red-bean.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1383077425 18280 80.91.229.3 (29 Oct 2013 20:10:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Oct 2013 20:10:25 +0000 (UTC) Cc: 15746@debbugs.gnu.org To: Karl Fogel , Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 29 21:10:28 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VbFcP-0004Zu-Ku for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Oct 2013 21:10:25 +0100 Original-Received: from localhost ([::1]:49209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbFcP-0006FB-5G for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Oct 2013 16:10:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbFcC-00063A-PH for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 16:10:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbFc4-0000nv-6N for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 16:10:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbFc4-0000mL-2W for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 16:10:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VbFc2-000202-TN for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2013 16:10:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Oct 2013 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15746-submit@debbugs.gnu.org id=B15746.13830773777649 (code B ref 15746); Tue, 29 Oct 2013 20:10:02 +0000 Original-Received: (at 15746) by debbugs.gnu.org; 29 Oct 2013 20:09:37 +0000 Original-Received: from localhost ([127.0.0.1]:51531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbFbc-0001zJ-Lo for submit@debbugs.gnu.org; Tue, 29 Oct 2013 16:09:37 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:41736) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbFbZ-0001z5-Gd for 15746@debbugs.gnu.org; Tue, 29 Oct 2013 16:09:34 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r9TK9QVH021359 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 Oct 2013 20:09:27 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9TK9PPf020284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 Oct 2013 20:09:26 GMT Original-Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9TK9Pm9017040; Tue, 29 Oct 2013 20:09:25 GMT In-Reply-To: <87iowg9bqw.fsf@floss.red-bean.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79758 Archived-At: > I think most users would expect that that *interactively* setting a > bookmark would confirm when overriding a previous bookmark of the > same name, instead of just silently overwriting it. There are plenty of use cases where you want to silently *update* an existing bookmark, e.g., update its location. That's the point of `bookmark-set': it both creates and updates. > Drew might be right that `bookmark-set' should not include this > functionality itself, but then there should be a wrapper function, > and every interactive key (C-x r m) currently default bound to > `bookmark-set' should be instead set to that wrapper function, then. > IOW, that question is just a matter of internal code orgainzation, > not of user-visible functionality. That effectively just *replaces* interactive use of `bookmark-set' with the proposed alternative behavior. That is exactly what I object to. I do not object to adding a different command, and either not binding it by default (users can choose to do that) or binding it to a different key. That lets users choose the behavior they want, and if they for some reason want there to be only one of the behaviors then they can easily bind both keys to the same command or unbind a key. And I do not object to adding a user option that thus conditionally changes the behavior of `bookmark-set'. The first approach of these two alternatives gives the most flexibility. With it, they need not choose the behavior once and for all but can instead just choose which behavior they want to invoke in any given context. My point is that it is a mistake to think there is only one interactive use of `bookmark-set' and that for that one use users would want to be queried wrt overwriting. There are lots of kinds of bookmarks, and lots of different uses of bookmarks. And some of those call precisely for silently updating an existing bookmark.