From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: master 87e422f: Beef up the Emacs string utility set a bit Date: Mon, 21 Dec 2020 15:44:51 -0500 Message-ID: References: <20201221175345.27592.89597@vcs0.savannah.gnu.org> <20201221175347.9F1B820B76@vcs0.savannah.gnu.org> <87eejjdn8e.fsf@gnus.org> <87a6u7dmnw.fsf@gnus.org> <8735zydhkq.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29554"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 21 21:47:05 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krS5A-0007a2-S1 for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Dec 2020 21:47:04 +0100 Original-Received: from localhost ([::1]:34658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krS59-0000Sk-UJ for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Dec 2020 15:47:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krS36-0007iu-82 for emacs-devel@gnu.org; Mon, 21 Dec 2020 15:44:56 -0500 Original-Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]:33415) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krS34-0006jP-M4 for emacs-devel@gnu.org; Mon, 21 Dec 2020 15:44:56 -0500 Original-Received: by mail-qv1-xf2a.google.com with SMTP id a13so5077573qvv.0 for ; Mon, 21 Dec 2020 12:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zeN8RM2l4d/qa0cRWpmuHlvPuCYygta3+iSTiSszkRQ=; b=UtUHkjoR7S/Ry7jaz0Alrs7bhm4UZbvzdnkt8OIc2pffKEAvLNnKnOot3BtBuO5kNc ln5bNXz8XFhppxznNDdGPWGStRK+9j8NWRqdKtDMnRdbEap3ArDnZEx8NmT9IwPlaOz7 YBRDMBep7fEwMKjicuwBEztY4Yz47DD+5Y54yGViIusqiNcrLtZVVI/wdR5vZeFFYaIu vKS67IURV9zYZcqNVCTaybqKoHrGtCWBbG7NFZEGeqinZRQukojYwpDOwMef9X/+pNHg XNxV5+5haMX5A/nwxG6i0nxS0RigPCmKVeFtlMs0gYt6xlwA0+d+s/AOrQVp0fmvH5LS 6vuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zeN8RM2l4d/qa0cRWpmuHlvPuCYygta3+iSTiSszkRQ=; b=MV7X70o6VQdTD04dFSB3yzroSiLrDACqjDFTA8FGlItXDUYtHfsS8vNI1uVQLCdR+/ la2dpDoCvlu2js/2pSnEc1UlHBLSpxTyIjY3rfah0Ii7fVmiao7T5cfvvJdFktBlxQ8F YuGOSLQ6HflBX7Tujf++kdlsKNhb7aR06Gl+iVkNeiWu3gNpLD422CvGR1VQ6LbKuMID 23YtaWxjRscHH0DMrCrGF+ToP5AWyvrW92Fyigb8VWsC/Yue4uZjnIfQ+NMBFoEjFI5D 92isk9MpMCSD/ggNnUWU67W/SCsWAZfsCUfoqAxIHl5B1Diqa71O+cdLMwSJN4Ocm5GR t6yg== X-Gm-Message-State: AOAM530rIf6lUJs/yTVhyRBIPZzZ/vq98PFBPrgC11JTj8IDSh11rmCH u2bdLUHqloSTSafIuO1DtCxbTAmSnJQ= X-Google-Smtp-Source: ABdhPJw5nIWrnCfCSJiKcM4ys0d0+mRJVSFrYR8HcukpBRyHO0FD/S3+LI69kJn7CxD8cNBn8cqfLg== X-Received: by 2002:a0c:b65f:: with SMTP id q31mr11753856qvf.24.1608583493551; Mon, 21 Dec 2020 12:44:53 -0800 (PST) Original-Received: from [192.168.1.3] (c-24-61-240-80.hsd1.ma.comcast.net. [24.61.240.80]) by smtp.googlemail.com with ESMTPSA id w34sm4781099qtd.89.2020.12.21.12.44.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Dec 2020 12:44:52 -0800 (PST) In-Reply-To: <8735zydhkq.fsf@gnus.org> Content-Language: en-GB Received-SPF: pass client-ip=2607:f8b0:4864:20::f2a; envelope-from=cpitclaudel@gmail.com; helo=mail-qv1-xf2a.google.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.233, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261435 Archived-At: On 12/21/20 3:34 PM, Lars Ingebrigtsen wrote: > Clément Pit-Claudel writes: > >> Look for (replace-regexp-in-string "\n$" "" and variants, or >> string-trim-right. One common use case is in conjunction with >> shell-command-to-string. Even if it was in Emacs, though, I'm not >> sure I'd find it and use it instead of string-trim-end. > > I see one single instance: > > ~/src/emacs/trunk/lisp/allout.el:6071: (replace-regexp-in-string "\n$" "" > > Hm... should that be "\n\\'"? Yup, probably. There's another one in sml.el; I don't have a good way to check across ELPA: ;; Strip the newline, to avoid adding a prompt. (if (string-match "\n\\'" eol) (replace-match " " t t eol) eol)