From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59662: 29.0.50; [PATCH] Add treesit--indent-defun Date: Fri, 9 Dec 2022 16:56:37 +0200 Message-ID: References: <5B538888-E454-4F75-B3B8-AB20E10B3E89@gmail.com> <83r0xhdluq.fsf@gnu.org> <3e25eadb-3f2b-f92d-8b18-bf1daca91b64@yandex.ru> <83wn78cqz4.fsf@gnu.org> <4d605e69-7df9-6480-c1c5-dcb22abd3bde@yandex.ru> <83y1ri2wnj.fsf@gnu.org> <875yemz55b.fsf@thornhill.no> <83r0xa2tc4.fsf@gnu.org> <87zgbyxohf.fsf@thornhill.no> <837cz22bgd.fsf@gnu.org> <2C2420B5-A0BE-4A81-A924-0F40DD57F211@thornhill.no> <877cz1d7vq.fsf@thornhill.no> <83ilil1wot.fsf@gnu.org> <877E42C0-4FDD-4ED7-933D-AB2199BBCEF3@thornhill.no> <83edt917z5.fsf@gnu.org> <87o7scww07.fsf@thornhill.no> <40acda30-cf00-b419-b726-2794206c96e9@yandex.ru> <87ilikws6a.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18884"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: larsi@gnus.org, 59662@debbugs.gnu.org, casouri@gmail.com, monnier@iro.umontreal.ca To: Theodor Thornhill , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 09 15:57:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3eoR-0004hF-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Dec 2022 15:57:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3eoB-0005JF-Rc; Fri, 09 Dec 2022 09:57:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3eoA-0005Ij-Nv for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 09:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3eoA-0003rC-GS for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 09:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3eoA-0005T9-CL for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 09:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2022 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59662 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59662-submit@debbugs.gnu.org id=B59662.167059780721011 (code B ref 59662); Fri, 09 Dec 2022 14:57:02 +0000 Original-Received: (at 59662) by debbugs.gnu.org; 9 Dec 2022 14:56:47 +0000 Original-Received: from localhost ([127.0.0.1]:36555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3env-0005Sp-1V for submit@debbugs.gnu.org; Fri, 09 Dec 2022 09:56:47 -0500 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:33647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3ent-0005Si-PN for 59662@debbugs.gnu.org; Fri, 09 Dec 2022 09:56:46 -0500 Original-Received: by mail-wr1-f43.google.com with SMTP id bx10so5484037wrb.0 for <59662@debbugs.gnu.org>; Fri, 09 Dec 2022 06:56:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=j0UMZVtoIrM7NpOAWTv/tmgRekK2GfSo3T82j9lTvAI=; b=gm7DxCqpL2aM/REF+tNMvGqEJGFoayJNlWwGJ7yD8FBLsQbzcvVH7bxD+Ft2np7Wg7 Vo38Dnh//ml46KSqGG1E/32anTfcOdcXcIBqUPEHs1YA0g35d3PtOrNHzWqarxhRnOnP rmZHEAnZRqPKr9eR1c4T9EqI/y8gFLmhLfLqnYqdE/4Ho+bRlTKAqMfJWuY48ZdhXMhb soKS3lCqSsNFunx6p5V9vjxB7NvzrMmesb3HLMivVUyKoO4SRyM2S35mR639pM/th29a GHvBd+IB5giGF+/AxbVjfm4zqp6nY4+ydIht9MqHDK7N2Xi5YSFD1f407z2kqLW2E1zy iTWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j0UMZVtoIrM7NpOAWTv/tmgRekK2GfSo3T82j9lTvAI=; b=1m+1+ZXhMTTJTnXur6KoSqVRCE1q0TK/08VTKoGS9VN271yoSBVpBVBwfH/cXRBw9i X/J9S00NoBzP0linWtzXrOsnQ3fHnc67vtyxkPHCx864lc7LsGcbc8I6Nu0KkCVwvz/6 oX5DmkJoFldK7xxKrWbXkbKttr3KMVW7sVH9/mJcpcpSX36tKAdi60gZB6tyfv1ZtK43 xk9Kn+NR4gDxslTiMPHgjR7mis3W848t12tHlMumLmPm+2dv0EOQCHcrYStfLTWy1hJL R6Wbzf90/RLSHlgLukeHmnxooDtO6BOM9fxLSLsekUb+/yy/Ye76uw+A8XVmrNR8Um7A bOtQ== X-Gm-Message-State: ANoB5pkW/IJ46WNMzrbrUVf8UKBUPyMEKQhA66vsu6SucY2BJ9OUM8sG KDhfNUk49sg1OtwbZa5nE2g= X-Google-Smtp-Source: AA0mqf7lpAe+niXTWAOJSLRGEsj2rQXEO2A/i6+9S+lXXyL2mNCG1dFMWeMKeZrbocc7mwjfix1GeQ== X-Received: by 2002:adf:eb4e:0:b0:232:be5c:bff6 with SMTP id u14-20020adfeb4e000000b00232be5cbff6mr4050852wrn.41.1670597799675; Fri, 09 Dec 2022 06:56:39 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id g4-20020a5d46c4000000b00228d52b935asm1601880wrs.71.2022.12.09.06.56.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Dec 2022 06:56:38 -0800 (PST) Content-Language: en-US In-Reply-To: <87ilikws6a.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250403 Archived-At: On 09/12/2022 16:46, Theodor Thornhill wrote: > Dmitry Gutov writes: > >> On 09/12/2022 15:24, Theodor Thornhill via Bug reports for GNU Emacs, >> the Swiss army knife of text editors wrote: >>> Ok! Here's the patch. What do you all think? >> >> - The NEWS entry probably doesn't need to mention syntax-ppss or >> tree-sitter. Those are just implementation details. >> >> - treesit-text-type-regexp could have a default value. (regexp-opt >> '("comment")) seems popular enough. >> > > Something like this? Yes. But... :-) I guess you can replace (regexp-opt '("comment")) with just "comment"? Both regexps are equivalent, and neither uses anchoring (like \` and \'). Should they have anchoring? The programs.texi addition should probably mention refilling too. And I see some additional changes in this patch, including ones that improve defun navigation, font-lock and indentation, in particular in java-ts-mode (but also json and typescript). These changes should probably go to emacs-29.