From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39379: 27.0.60; Fix for #38457 broke ido-vertical-mode Date: Tue, 4 Feb 2020 16:19:05 +0300 Message-ID: References: <83a762k9p2.fsf@gnu.org> <71c2898c-aca7-ea92-e7d2-f4fd122b566d@gmail.com> <83ftfthsqs.fsf@gnu.org> <83d0awj42l.fsf@gnu.org> <83a760j23r.fsf@gnu.org> <838slkj0mk.fsf@gnu.org> <17d792bd-c96f-0440-7127-5308cc34f158@gmail.com> <83y2tjhe6l.fsf@gnu.org> <4b167bc3-0240-cb51-a004-6d9e1a84d0a4@yandex.ru> <83pnevghgp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="124736"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 39379@debbugs.gnu.org, wyuenho@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 04 14:21:57 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iyy9N-000WLy-9L for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Feb 2020 14:21:57 +0100 Original-Received: from localhost ([::1]:58322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyy9M-00040Z-7V for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Feb 2020 08:21:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47273) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyy7Z-0001yB-Fv for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 08:20:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyy7W-0004rT-Fm for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 08:20:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iyy7V-0004p4-PB for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 08:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iyy7V-0007EJ-LQ for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 08:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Feb 2020 13:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39379 X-GNU-PR-Package: emacs Original-Received: via spool by 39379-submit@debbugs.gnu.org id=B39379.158082235527730 (code B ref 39379); Tue, 04 Feb 2020 13:20:01 +0000 Original-Received: (at 39379) by debbugs.gnu.org; 4 Feb 2020 13:19:15 +0000 Original-Received: from localhost ([127.0.0.1]:42802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyy6k-0007DC-Qe for submit@debbugs.gnu.org; Tue, 04 Feb 2020 08:19:15 -0500 Original-Received: from mail-lf1-f49.google.com ([209.85.167.49]:44302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyy6j-0007Cx-H6 for 39379@debbugs.gnu.org; Tue, 04 Feb 2020 08:19:13 -0500 Original-Received: by mail-lf1-f49.google.com with SMTP id v201so12127260lfa.11 for <39379@debbugs.gnu.org>; Tue, 04 Feb 2020 05:19:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cZV4dnAafHxca7OgSh1vtH6aya3ISldgjw/vZRNc4GU=; b=S3ZAyTzFz1FeVEBbdltJLVibrj1aXBamhMMyP9RW5qkPlHzaNMF7d97H9VEhDw0T+/ tYdRDM1magJ3D1ytLsSLLmF09/fjFQMeI7y7Yhuly53LfuocENk6IGe/XYVat22kOtoG zD8HZxS9ZbhwiiXajqMtUtQGcllltcueS9eZZlLx8xNvrRiB8jkZKlobg3vuDnckho7c mtMaVzCVgAzRrSx59/MEh/cMJqNggusYZTz6MmVN1474fCSmM7XKEg+/UJFuo+8kQOg+ B7jcsIEolKBEPGYk7wQRwdFZgWQp9iLH6yFSSOS6Bv9eIEumqOuvteubgJRoOf7ISmhL YdhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cZV4dnAafHxca7OgSh1vtH6aya3ISldgjw/vZRNc4GU=; b=lv6YgL/wPOhw1hNzHotFnLZiZF6ZejM285JER9QwR5XjcFckzxau1DzRuXEKywcQqW O7zIR4fapJrubzs3BK9hegBC2z9AIwNPcQXGe+QKOJIvWenNo+QhmoCGtNqIlbFPPJMj udZifyhOh9tREMrDnahY38WtjBey0xmXv4Ckb6eeNYu5L3XwxpTfbtOrey6cCTCc9yak Uz8rtNac+eqWn6P7YVxf43Xph4p7nTvKdABDndqRwwjdNZlIDhjYw96XKpU0EghYOytC Gp8LhvycbPlii+sjXYBr0ceRQVQzE1O6aaKRDNAgvklupIm23IwarMgTxu4OETHHlPYI D8yw== X-Gm-Message-State: APjAAAUPHny6pipSsIA3hf+d5gkWWrqKn7jv0u30Q4J6FKpou3azFZXF CutY9BjGdsiWdnP2Uafy0YE= X-Google-Smtp-Source: APXvYqzpOq4XrHL0BaHnaiJGuRBMBhOlrG7zoysklYZdYyIp6gasA4DBB1ZfxFYnRMZ/yP3C7fp/Gw== X-Received: by 2002:ac2:5509:: with SMTP id j9mr14793821lfk.135.1580822347387; Tue, 04 Feb 2020 05:19:07 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id z8sm11457415ljc.44.2020.02.04.05.19.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Feb 2020 05:19:06 -0800 (PST) In-Reply-To: <83pnevghgp.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175664 Archived-At: On 04.02.2020 6:27, Eli Zaretskii wrote: > I think this is for ido.el to do: it is ido.el that puts the cursor on > the overlay string, so it is up to it to make sure the cursor can be > put where it puts the 'cursor' property. It's a simple change: if the > text to be displayed starts with a newline, prepend a SPC to it when > defining the after-string. But... the change in ido-vertical-mode is simpler still: just add an extra argument to concat. If we do that in ido.do, the reason why would be fairly non-obvious from that code. After all, we don't provide any customization points in there, hooks or otherwise. So we risk accidentally losing that change in some future version.