From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Eglot, project.el, and python virtual environments Date: Sat, 19 Nov 2022 21:49:16 +0200 Message-ID: References: <87zgcq68zp.fsf@ericabrahamsen.net> <878rkale3l.fsf@dfreeman.email> <4c5f4b07-3df6-d700-83f8-9a9d1b684afc@yandex.ru> <84781346-5b88-2be5-38bb-02696fcf1364@yandex.ru> <87o7t2vj19.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2896"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Eric Abrahamsen , emacs-devel To: Danny Freeman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 19 20:50:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owTqu-0000cR-RS for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Nov 2022 20:50:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owTqG-00062Y-Aq; Sat, 19 Nov 2022 14:49:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owTqF-00062E-2S for emacs-devel@gnu.org; Sat, 19 Nov 2022 14:49:31 -0500 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owTqD-0006kN-6k for emacs-devel@gnu.org; Sat, 19 Nov 2022 14:49:30 -0500 Original-Received: by mail-wr1-x429.google.com with SMTP id d9so14241285wrm.13 for ; Sat, 19 Nov 2022 11:49:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=3nCEJ0b/mcetvKcIqKL1/1q+zCh7hldjw461PZ3KUU0=; b=CUKn2UXyBoHtPUuUuwoe2k74KJTeYsfZBrVb8jXdb6SXp9Nvl1uSa2GmmUTB8yRA8y 1hdlhrxkY8jBpbDqBvxDMw6bELFdjhPiCNFzUJyPazomS6AYGYHqDIczKH9RSt73lRq1 z3+wMBF3B3rSSGiNCARzUpRYfR+A0a17b/9qqHCVIlN/xDgEIy/RHgLHxkwHlTTC6mHa 0uwGdSbsC2dnPe3zJgP6mtFYIvNlCvt8A88OA9BePdXOR2fWzEFN91FkFE1RmRikXmcM cS0pezjcNfGn/NQJsjGqrKhPn4dii5sxzj+V7VyWykNtfTpkGNDO+2+nfIgh+oHetAeV PRZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3nCEJ0b/mcetvKcIqKL1/1q+zCh7hldjw461PZ3KUU0=; b=58KtPQnPAH+2aH4bL2rWd5XcwxChUqv27oJyYGITLtuTA5rO0DVaBhnZYdz1x5ZoPX b0ZWXVSMsmMtdDoY1t2CdTCukgoaPBoR9Zhkjk7HgD6k68/ygtNVVxRRxZeEj5wcnjPr GiN3rnWOs+6LzAFB8TPGfY033/ObfTjSHo+EDIQG7Kox+rDBZUDgTMLMYWZVBYIQh8/n by9DT00ohrbHzrW0cQpUGK8f9TK3CShDZuGawUT7mjGyQ6pTGK9YUXrMNle7z5wiKKK1 /DbA+7Dqo8RRYORqz88Ve4AMbHYn//xQ4t/WIp8BkwFQnuYNWeHTWvKvQO9Zo3WbAmIK X8cA== X-Gm-Message-State: ANoB5pkdn/Njae71+wUQ84JgT1BccsGE9fFpVX3xFxv7/8btLQIKb5Lm Taw3fJ803CmMGpOmlVTLX2Y= X-Google-Smtp-Source: AA0mqf5CjJF3SiGPFohi9k5QDgKs8/ypfjJHwNyEUcq0RP9jfUXSvt6PD73FyFsLRVjz5DF2mL1sdw== X-Received: by 2002:adf:df09:0:b0:236:885e:ef4b with SMTP id y9-20020adfdf09000000b00236885eef4bmr7348040wrl.13.1668887359038; Sat, 19 Nov 2022 11:49:19 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h5-20020a05600c350500b003c6b70a4d69sm9143010wmq.42.2022.11.19.11.49.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 11:49:18 -0800 (PST) Content-Language: en-US In-Reply-To: <87o7t2vj19.fsf@dfreeman.email> Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=raaahh@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300202 Archived-At: Ah, sorry, I missed that part: On 19.11.2022 21:17, Danny Freeman wrote: > For reference this is the code I'm talking about: > ``` > (defun project-find-virtualenv-for-eglot (dir) > > (when eglot-lsp-context ;; ALWAYS NIL, except when called from `eglot--curent-project` Then your solution should work okay, but it also means it belongs to the category of Eglot hacks (as opposed to project.el hacks). Since this issue seems to be common enough, though, we should decide on a proper fix for it, too.