all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Emacs-diffs] master 2475687: Improve documentation changes of a recent commit
Date: Sun, 14 Apr 2019 13:34:51 +0300	[thread overview]
Message-ID: <f4b79118-8189-d260-7051-a0c9fa1eac02@yandex.ru> (raw)
In-Reply-To: <20190413070934.DDF7B202C6@vcs0.savannah.gnu.org>

Hi Eli,

On 13.04.2019 10:09, Eli Zaretskii wrote:
>          doc: /* Read JSON object from current buffer starting at point.
> -This is similar to `json-parse-string', which see.  Move point after
> -the end of the object if parsing was successful.  On error, point is
> -not moved.
> +Move point after the end of the object if parsing was successful.
> +On error, don't move point.
> +
> +The returned object will be a vector, list, hashtable, alist, or
> +plist.  Its elements will be the JSON null value, the JSON false
> +value, t, numbers, strings, or further vectors, lists, hashtables,
> +alists, or plists.  If there are duplicate keys in an object, all
> +but the last one are ignored.
> +
> +If the current buffer doesn't contain a valid JSON object, the
> +function signals an error of type `json-parse-error'.
> +
> +The arguments ARGS are a list of keyword/argument pairs:
> +
> +The keyword argument `:object-type' specifies which Lisp type is used
> +to represent objects; it can be `hash-table', `alist' or `plist'.  It
> +defaults to `hash-table'.
> +
> +The keyword argument `:array-type' specifies which Lisp type is used
> +to represent arrays; it can be `array' (the default) or `list'.
> +
> +The keyword argument `:null-object' specifies which object to use
> +to represent a JSON null value.  It defaults to `:null'.
> +
> +The keyword argument `:false-object' specifies which object to use to
> +represent a JSON false value.  It defaults to `:false'.

FTR, I quite dislike this kind of duplication in docstrings.

Didn't we discuss the difference between docstrings and manuals some 
time ago, where you expressed the opinion that docstrings are allowed 
the kind of "see XX for more detail" references, and it's the manuals 
where information sometimes has to be reiterated for the convenience of 
the reader? Here you seem to have made the reverse choice.



       reply	other threads:[~2019-04-14 10:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190413070933.31645.83730@vcs0.savannah.gnu.org>
     [not found] ` <20190413070934.DDF7B202C6@vcs0.savannah.gnu.org>
2019-04-14 10:34   ` Dmitry Gutov [this message]
2019-04-14 14:40     ` [Emacs-diffs] master 2475687: Improve documentation changes of a recent commit Eli Zaretskii
2019-04-14 20:34       ` Dmitry Gutov
2019-04-15 14:57         ` Eli Zaretskii
2019-04-15 15:42           ` Dmitry Gutov
2019-04-15 16:06             ` Eli Zaretskii
2019-04-15 17:15               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4b79118-8189-d260-7051-a0c9fa1eac02@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.