all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: emacs-devel@gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Cc: Bruno Haible <bruno@clisp.org>
Subject: Re: [Emacs-diffs] master 100e339: Update from gnulib
Date: Mon, 26 Feb 2018 15:25:00 -0500	[thread overview]
Message-ID: <f4ae7810-e9e7-5107-d2b0-8c9b9cce9216@cornell.edu> (raw)
In-Reply-To: <20180201172144.5A58620856@vcs0.savannah.gnu.org>

On 2/1/2018 12:21 PM, Paul Eggert wrote:
> +# if defined __CYGWIN__
> +/* The 'environ' variable is defined in a DLL. Therefore its declaration needs
> +   the '__declspec(dllimport)' attribute, but the system's <unistd.h> lacks it.
> +   This leads to a link error on 64-bit Cygwin when the option
> +   -Wl,--disable-auto-import is in use.  */
> +_GL_EXTERN_C __declspec(dllimport) char **environ;
> +# endif

This breaks the build on 32-bit Cygwin.  The build fails as follows:

   CCLD     make-docfile.exe
/tmp/ccZciFa6.o: In function `main':
/home/kbrown/src/emacs/i686/lib-src/../../master/lib-src/emacsclient.c:1740: 
undefined reference to `_imp__environ'
collect2: error: ld returned 1 exit status

Bruno is aware of the issue; I first noticed it while building clisp and 
reported it there.  But I thought I should report it here too in case 
others bump into it.

Ken



       reply	other threads:[~2018-02-26 20:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180201172143.17217.47676@vcs0.savannah.gnu.org>
     [not found] ` <20180201172144.5A58620856@vcs0.savannah.gnu.org>
2018-02-26 20:25   ` Ken Brown [this message]
2018-02-26 23:26     ` [Emacs-diffs] master 100e339: Update from gnulib Paul Eggert
2018-02-26 23:51       ` Ken Brown
2018-02-27 17:10         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4ae7810-e9e7-5107-d2b0-8c9b9cce9216@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=bruno@clisp.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.