Re: master 5f9b5803bea: Fix zooming images in SHR

[Jim Porter <jporterbugs@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

On 6/28/2024 5:04 AM, Eli Zaretskii wrote:
> I'd prefer to defer the decision about skipping until we fully
> understand what happens here.  If the output below doesn't give a
> clue, could you perhaps explain to me the idea of this test in more
> detail, so I could perhaps also think about the reasons?

I had a sudden realization about what the problem might be. I *think* 
this patch should resolve the issue. Could you try it?

The issue (I believe) is that on MS-Windows, the "file:" URL to the 
image we're trying to load wasn't formatted correctly. That meant that 
'url-retrieve' never successfully loaded the image, so the test stalled.

If that *doesn't* fix the issue, here's a quick summary of what the test 
is doing:

1. Load a simple HTML page with an image (using one from the test directory)
2. Wait for SHR to insert the real image, which happens asynchronously.
3. Put point on the image and call 'shr-zoom-image'.
4. Wait for SHR to insert the updated image.
5. Check that we have a new (sliced) image in the buffer.

(The test repeats the above steps for a few different cases, each with 
different values of the HTML "alt" attribute.)

[-- Attachment #2: 0001-Fix-SHR-test-on-MS-Windows.patch --]
[-- Type: text/plain, Size: 1747 bytes --]

From 50301f502c7e32efe34ca3db3bf0c1c64ccd5df8 Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Fri, 28 Jun 2024 10:40:05 -0700
Subject: [PATCH] ; Fix SHR test on MS-Windows

* test/lisp/net/shr-tests.el (shr-test/zoom-image): Ensure the image URL
is properly formatted: it should always have 3 slashes after "file:".
---
 test/lisp/net/shr-tests.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/test/lisp/net/shr-tests.el b/test/lisp/net/shr-tests.el
index 4864fc488e2..1f8dcd57cbe 100644
--- a/test/lisp/net/shr-tests.el
+++ b/test/lisp/net/shr-tests.el
@@ -136,13 +136,15 @@ shr-srcset
 (ert-deftest shr-test/zoom-image ()
   "Test that `shr-zoom-image' properly replaces the original image."
   (skip-unless (bound-and-true-p image-types))
-  (let ((image (expand-file-name "data/image/blank-100x200.png"
-                                 (getenv "EMACS_TEST_DIRECTORY"))))
+  (let* ((image (expand-file-name "data/image/blank-100x200.png"
+                                  (getenv "EMACS_TEST_DIRECTORY")))
+         (image-url (concat "file://" (if (string-prefix-p "/" image)
+                                          image (concat "/" image)))))
     (dolist (alt '(nil "" "nothing to see here"))
       (with-temp-buffer
         (ert-info ((format "image with alt=%S" alt))
           (let ((attrs (if alt (format " alt=\"%s\"" alt) "")))
-            (insert (format "<img src=\"file://%s\" %s" image attrs)))
+            (insert (format "<img src=\"%s\" %s" image-url attrs)))
           (cl-letf* (;; Pretend we're a graphical display.
                      ((symbol-function 'display-graphic-p) #'always)
                      ((symbol-function 'url-queue-retrieve)
-- 
2.25.1