From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#64516: [PATCH] docview: Only enable imenu when supported Date: Sun, 16 Jul 2023 06:39:57 +0200 (GMT+02:00) Message-ID: References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16131"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org To: Morgan Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 06:41:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKtZX-00043u-Q4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 06:41:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKtZE-0007fe-5G; Sun, 16 Jul 2023 00:41:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKtZ8-0007fJ-8q for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 00:41:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKtZ8-00061D-0b for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 00:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKtZ7-0001iM-T2 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 00:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 04:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64516 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64516-submit@debbugs.gnu.org id=B64516.16894824136518 (code B ref 64516); Sun, 16 Jul 2023 04:41:01 +0000 Original-Received: (at 64516) by debbugs.gnu.org; 16 Jul 2023 04:40:13 +0000 Original-Received: from localhost ([127.0.0.1]:46352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKtYK-0001h4-SA for submit@debbugs.gnu.org; Sun, 16 Jul 2023 00:40:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKtYH-0001gn-3a for 64516@debbugs.gnu.org; Sun, 16 Jul 2023 00:40:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKtYB-0005lP-7m; Sun, 16 Jul 2023 00:40:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Subject:References:In-Reply-To:To:From: Date; bh=Wscty2/2qGZJ0ithas3udBxYVKbqAe1K0aZEB9VyKqc=; b=MrwDWon1rDIY06LdIuRp Nd60belEy+sE/EKfq9FQAK3NVww1WyuFPJjMD2i6BJKdKozdTdJY/QmDW8irvaw91cY94cwguPY7J ZkghymmiIX/19QCT5lqv8QkExi8efucCEsz606ikmatIOpMiOQIgW0K5xex/fYQARV8t7QzwNBDdy zE0b82qC7hjIZhRz5WCkS7KNLNwcHSLQmInwfn22UhsAbFtbRFdtouQylCYi91oho4M2JX/ZH/1Ng /WxtK2dusE9x8C3uIoqAWxE1guZf2oz4jzNf5/HdRJtO++q7FfxEWSl1AGz8UkvsBkAI9QKof6i0Q XXc4p5dSA1APEg==; Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKtYA-0005VS-0u; Sun, 16 Jul 2023 00:40:02 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 02D7927C005A; Sun, 16 Jul 2023 00:40:00 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 16 Jul 2023 00:40:00 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfeelgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefkjghfufggtgfgsehtqhertddttdejnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhephf duhfejjedvtdfhteejtdejgeeiudeiueduteeuhfffgfehhedtvddvheeugeeunecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 16 Jul 2023 00:39:58 -0400 (EDT) In-Reply-To: X-Correlation-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265259 Archived-At: Hi Morgan, Why do you ignore the error altogether? FWIW, just use the patch from my la= st message and we're good to commit. Thanks, Tassilo 16.07.2023 01:56:09 Morgan Smith : > Tassilo Horn writes: >=20 >>=20 >> Yes, almost.=C2=A0 I'd rather handle the error rather putting the setup >> function in a hook and let the error hit top-level and flash the screen. >>=20 >=20 > I've made the requested change.=C2=A0 Please see attached. >=20 > Thank you, >=20 > Morgan