From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#25599: Why edit markers after insert? Date: Sat, 17 Jun 2017 04:06:35 +0300 Message-ID: References: <28211825-9989-bd18-1f53-891506af9adf@yandex.ru> <8737en1xdg.fsf@linux-m68k.org> <13792565-9d57-7546-0a81-09aec09a7705@yandex.ru> <87r2yqv1j3.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1497661632 19133 195.159.176.226 (17 Jun 2017 01:07:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Jun 2017 01:07:12 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 Cc: 25599-done@debbugs.gnu.org, Andreas Schwab , nitish chandra To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 17 03:07:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dM2Ch-0004jX-99 for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 03:07:07 +0200 Original-Received: from localhost ([::1]:32991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dM2Cm-0006mC-Cr for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Jun 2017 21:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dM2Cg-0006ko-3w for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 21:07:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dM2Cd-0002Ue-0D for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 21:07:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49181) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dM2Cc-0002UE-Sa for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 21:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dM2Cc-00070f-DE for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 21:07:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2017 01:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 25599@debbugs.gnu.org, dgutov@yandex.ru, dgutov@yandex.ru Original-Received: via spool by 25599-done@debbugs.gnu.org id=D25599.149766160526918 (code D ref 25599); Sat, 17 Jun 2017 01:07:02 +0000 Original-Received: (at 25599-done) by debbugs.gnu.org; 17 Jun 2017 01:06:45 +0000 Original-Received: from localhost ([127.0.0.1]:51858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dM2CL-000705-Cr for submit@debbugs.gnu.org; Fri, 16 Jun 2017 21:06:45 -0400 Original-Received: from mail-wm0-f41.google.com ([74.125.82.41]:36235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dM2CK-0006zt-71 for 25599-done@debbugs.gnu.org; Fri, 16 Jun 2017 21:06:44 -0400 Original-Received: by mail-wm0-f41.google.com with SMTP id m125so38318595wmm.1 for <25599-done@debbugs.gnu.org>; Fri, 16 Jun 2017 18:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l5ztgMng1jgl4KOl2hhRu1jVMr6LD5w7HuKClL0fZxk=; b=iW2j3pN/9ZgBEtaCExlBmYN7G1lQ7SqHBr3CxnncRdRX/14f94u7w/vmxN35ViJ6Qr goSU8y9UEbatajO+omGdl00e8fSGSNF200E78PXcpRiwOH84fRyFl6RDTWWsdZh+ea5j ndcXdWTSnxD32ihqOQoiLCFSMitjP/e7tSpsy+iEgLA9q2Vd/mBs0dQvWQm+uEEbSOCJ QMrC9TMzxt7WS0/F5LXj1jkKKBN/M1dAq/5lwYNbiGPw0Fr1TyewHxcl3vgpyCYzaWLL Jp5PVaDTL76VHLITT5CYsaBHbFCxAiwBYWYF3n4ScD7SoEDS730C8F3mBoP/fjpSWjSi 05VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l5ztgMng1jgl4KOl2hhRu1jVMr6LD5w7HuKClL0fZxk=; b=XLKCJo6W6Whw1B0Qlo4z4Qw+pMfPgPLGNQBfzDlo2brVFKw74hgANf1fIkd0EW1jLE 8C2OEGkQLTAHQw+sTzhhiODgrCssm2M0JuBFjuYTvRLb9myZyl/Ls9LNPOZVpv3j9hod sCAdayPv+mofTXsvM5r1fekZ+3D0u+OYWAdXaw53pw+4wEvKNGR55VXysG6S+QHL0d7i Kd4bESO5EEM1mzMmaD4ZG3heatGgM8rYgaSlPqQVeYGsPHGLQSE2acYQ3gK8LbtUKSvZ rgsHvKohfVrFaNHtMBGyiMMo3O16L3U4HZIGrUxI0vpwrgk6vOq+VQXgJHsZVmsXI35m fe3g== X-Gm-Message-State: AKS2vOxR5PJIzUtsUHQfL332+yChisvJkeQqPcRGr7xTdk/W34KEotUS UiqXiYLC3cg5Rw== X-Received: by 10.28.153.75 with SMTP id b72mr8804818wme.46.1497661598438; Fri, 16 Jun 2017 18:06:38 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id l26sm3679296wrl.15.2017.06.16.18.06.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jun 2017 18:06:37 -0700 (PDT) In-Reply-To: <87r2yqv1j3.fsf@users.sourceforge.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133677 Archived-At: On 6/11/17 9:10 PM, npostavs@users.sourceforge.net wrote: > Not that I'm very familiar with the undo code, but the patch seems > obviously correct to me. > > + ;; insert might have invalidated some of the > + ;; markers. We update only the currently valid > + ;; markers. See bug#25599 > > I would augment the comment to specifically mention modification hooks > though (missing double spacing too). Good point. Added and pushed. Thanks all! Closing.