From: Dmitry Gutov <dgutov@yandex.ru>
To: npostavs@users.sourceforge.net
Cc: 25599-done@debbugs.gnu.org,
Andreas Schwab <schwab@linux-m68k.org>,
nitish chandra <nitishchandrachinta@gmail.com>
Subject: bug#25599: Why edit markers after insert?
Date: Sat, 17 Jun 2017 04:06:35 +0300 [thread overview]
Message-ID: <f447b521-190d-89dd-bd83-6a5b80d9c1e4@yandex.ru> (raw)
In-Reply-To: <87r2yqv1j3.fsf@users.sourceforge.net>
On 6/11/17 9:10 PM, npostavs@users.sourceforge.net wrote:
> Not that I'm very familiar with the undo code, but the patch seems
> obviously correct to me.
>
> + ;; insert might have invalidated some of the
> + ;; markers. We update only the currently valid
> + ;; markers. See bug#25599
>
> I would augment the comment to specifically mention modification hooks
> though (missing double spacing too).
Good point. Added and pushed.
Thanks all! Closing.
prev parent reply other threads:[~2017-06-17 1:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 14:18 bug#25599: 26.0.50; "Marker does not point anywhere" error signaled by primitive-undo near an overlay with an auto-removal insert-in-front-hooks value Dmitry Gutov
2017-03-08 16:14 ` bug#25599: Why edit markers after insert? nitish chandra
2017-03-08 17:39 ` Andreas Schwab
2017-03-08 18:08 ` nitish chandra
2017-03-08 18:17 ` nitish chandra
2017-03-09 19:39 ` nitish chandra
2017-05-14 1:12 ` Dmitry Gutov
2017-06-11 18:10 ` npostavs
2017-06-17 1:06 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f447b521-190d-89dd-bd83-6a5b80d9c1e4@yandex.ru \
--to=dgutov@yandex.ru \
--cc=25599-done@debbugs.gnu.org \
--cc=nitishchandrachinta@gmail.com \
--cc=npostavs@users.sourceforge.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.