bug#69651: 30.0.50; Theme-agnostic hook for theme loading

bug#69651: 30.0.50; Theme-agnostic hook for theme loading

[Andrea Ciceri via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Modus themes provide an hook for theme loading and the manual even
suggests a way to implement an agnostic hook that works for all the
themes using advices:

https://www.gnu.org/software/emacs/manual/html_node/modus-themes/A-theme_002dagnostic-hook-for-theme-loading.html

Why isn't such an hook provided upstream?

This is the first time I use the GNU bugs tracker and this is more like
a "kind request" than bug, I hope I did everything correctly.

If you confirm that it makes sense and should be added then I can try to
send a patch by myself (I'm not familiar with Emacs internals so
probably I need to figure out where this should be added before).

Thanks!


Andrea

bug#69651: 30.0.50; Theme-agnostic hook for theme loading

[Visuwesh]

[வெள்ளி மார்ச் 08, 2024] Andrea Ciceri via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:

> Modus themes provide an hook for theme loading and the manual even
> suggests a way to implement an agnostic hook that works for all the
> themes using advices:
>
> https://www.gnu.org/software/emacs/manual/html_node/modus-themes/A-theme_002dagnostic-hook-for-theme-loading.html
>
> Why isn't such an hook provided upstream?

enable-theme-functions added in Emacs 29.1 already does the job AFAIU.

> This is the first time I use the GNU bugs tracker and this is more like
> a "kind request" than bug, I hope I did everything correctly.
>
> If you confirm that it makes sense and should be added then I can try to
> send a patch by myself (I'm not familiar with Emacs internals so
> probably I need to figure out where this should be added before).
>
> Thanks!
>
>
> Andrea

bug#69651: 30.0.50; Theme-agnostic hook for theme loading

[Protesilaos Stavrou]

> From: Visuwesh <visuweshm@gmail.com>
> Date: Sat,  9 Mar 2024 15:09:49 +0530
>
> [வெள்ளி மார்ச் 08, 2024] Andrea Ciceri via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:
>
>> Modus themes provide an hook for theme loading and the manual even
>> suggests a way to implement an agnostic hook that works for all the
>> themes using advices:
>>
>> https://www.gnu.org/software/emacs/manual/html_node/modus-themes/A-theme_002dagnostic-hook-for-theme-loading.html
>>
>> Why isn't such an hook provided upstream?
>
> enable-theme-functions added in Emacs 29.1 already does the job AFAIU.

Indeed. The updated version of the modus-themes manual mentions this. I
have not published the new version yet, so it is not part of Emacs 30
and all the relevant GNU web pages. It is on my website though (which to
me is the canonical source, as I maintain it): https://protesilaos.com/emacs/modus-themes

-- 
Protesilaos Stavrou
https://protesilaos.com

bug#69651: Closing bug#69651: 30.0.50; Theme-agnostic hook for theme loading

[andrea.ciceri--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

I'm using enable-theme-functions now and it works as expected.
Thank you both!