From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: locked narrowing Date: Sat, 26 Nov 2022 22:42:35 +0000 Message-ID: References: <831qtgff78.fsf@gnu.org> <83zgg4dw4y.fsf@gnu.org> <83r11gdrr4.fsf@gnu.org> <83edxfds7s.fsf@gnu.org> <83r11fc80o.fsf@gnu.org> <83o7wjc6o2.fsf@gnu.org> <83lernc5gu.fsf@gnu.org> <83k076dd7d.fsf@gnu.org> <83czcyd8jf.fsf@gnu.org> <83a682d66r.fsf@gnu.org> <837d36ceno.fsf@gnu.org> <37dd2827f54f8bbda5e3@heytings.org> <83fse6t4d5.fsf@gnu.org> <83a64dslpi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32756"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 23:43:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oz3tK-0008MW-AL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 23:43:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz3t2-0006xq-MR; Sat, 26 Nov 2022 17:43:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz3t1-0006xT-11 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 17:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oz3t0-0007mY-OW for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 17:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oz3t0-00086C-9a for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 17:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 22:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.166950256031121 (code B ref 56682); Sat, 26 Nov 2022 22:43:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 26 Nov 2022 22:42:40 +0000 Original-Received: from localhost ([127.0.0.1]:41647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz3se-00085t-Ck for submit@debbugs.gnu.org; Sat, 26 Nov 2022 17:42:40 -0500 Original-Received: from heytings.org ([95.142.160.155]:60830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz3sb-00085n-IK for 56682@debbugs.gnu.org; Sat, 26 Nov 2022 17:42:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669502556; bh=yokivthfwlJ825F0BplEP1T04n8EwylEt+AZNhekAhg=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=30eAJ9zNwaVYfuEMOr6/bhFhewiSnqgyYcWotS9w9F41J+oG75D6Bt0QUT37A9IvC 1oLVEt+fPfTIhpXh13U9zypUmSuKYJFlR7RUYIrQ3ZIyV8oUDXYocvmfIAU4nYgUce 7vFoHernr+uynsq9WVq7aWOqlEFB/mvGgl9DGvIVrWLO8ObzIvbcKIpkHYbVmPCtOx bpe3SoZtEoUSylqwvuO/GnYMyxpRpicTYzhQxf4eZGMlEYrThGsP5+Mdcy1Exa0BDU eAEX6Q489jmH+cFwl+GqvTTtiQOJn9NcOI+ms6/BSlJxMiTwGDJh/NI6zXwbzJwosH U6UlbankK4uKg== In-Reply-To: <83a64dslpi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249148 Archived-At: > > I actually think these should not be called with-SOMETHING, since they > aren't macros. And yes, the function names should include "--". > Done, I went for internal--with-narrowing. >> Because 'pop' on an empty stack is an error > > You don't need to pop, just return without doing anything. > >> and (more importantly) it would mean that the narrowing_locks alist is >> corrupted. The cdr's in that alist should never be nil. > > A comment to that effect should be in order, then. > Sorry, I was confused, in fact just return'ing in that case is fine. >> Strictly speaking there is no need for an assertion, but again it would >> mean that something that isn't supposed to happen happened. In this >> case it would mean that narrowing_locks_restore is called with a list >> of length 1, containing only a buffer, whereas it is supposed to be >> called with the return value of narrowing_locks_save, which is either >> nil or a list of length >= 2. > > I don't think I understand (you avoid the assertion in other cases which > look similar to me), but if there are good reasons, please add comments > there explaining the rationale. > I'm just being extra cautious here. I added a comment to explain that assertion (and the previous one). > > We can add the tests after the branch is cut, I just wanted to be sure > we will have them eventually. > I'll do that.