From: Dmitry Gutov <dgutov@yandex.ru>
To: "João Távora" <joaotavora@gmail.com>,
"Danny Freeman" <danny@dfreeman.email>
Cc: 58790@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>
Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server
Date: Sat, 29 Oct 2022 04:22:43 +0300 [thread overview]
Message-ID: <f39bd6fa-903d-1723-8ec2-d7ffff4d4a9c@yandex.ru> (raw)
In-Reply-To: <87ilk5xq01.fsf@gmail.com>
On 27.10.2022 18:09, João Távora wrote:
> 4. B2 can be setup in a way so that project-current returns the same
> object which is returned in B. If this is true,
> eglot--current-server discovers the same connection which also
> manages B1 and Eglot adds buffer B2 to the list of managed buffers in
> that connection.
>
> However, if eglot-extend-to-xref is non-nil, eglot--current-server
> should also discover the correct connection. This is less ideal than
> making project-current know that the buffers of source code inside
> the jar are also in the same project, but it works. I can explain
> the downsides, but it's not very relevant right now.
This point seems to be key, to be able to continue 'M-.' from inside the
jar.
> 5. Upon findin the "file", Eglot transmits a :textDocument/didOpen
> notification to the server. This requires eglot--path-to-uri, the
> reciprocal of eglot--uri-to-path to convert the path Y to URI X
> again. Again, maybe this conversion is just #'identity.
>
> Eventually, the LSP server knows that the client is now working on a
> textDocument whose relationship to other opened documents in the
> workspace it understands (which may or may not be read-only).
>
> 6. xref-find-definition on any part of the B2 should now work similarly
> to this whole flow.
>
>> Dmitry: Sounds like you want to advise project-vc-external-roots-function. Or
>> Dmitry: change its whole value.
FWIW, project-external-roots might be a red herring for this discussion.
I just saw somebody mention project-external-roots, and the above would
be a way to add to that list.
> I don't understand that "vc" has to do with this. The above
> implementation should work with any project backend, not just VC.
Okay...
> To be clear, my suggestion was to add the ability to add a jar file to
> project-external-roots. Currently a root is a string representing a
> directory, per its docstring. But it could be generalized to a string
> representing any container of files.
Container or not, the return value of project-external-roots, just like
that of project-root, is determined by the project backend, its internal
structures, and how it is customized by the user.
We don't provide a setter for 'project-root', so I don't understand the
expectation of being able to modify project-external-roots for an
arbitrary project type either.
>> Dmitry: Or create an Eglot-specific project backend.
>
> I don't understand this suggestion either. Normally Eglot is a client
> of project information maintained by other project.el backends. Very
> commonly VC projects, but not always necessarily so. That clashes with
> the idea of making Eglot simultaneously a supplier of this information.
There is indeed certain tension, but if Eglot wants to decide stuff
about the project (which, as I said in the past, could be a reasonable
idea), then it could provide its own project backend. We're not
necessarily at that point, though, because...
> Please read the summary of the outlined above. Maybe there's nothing to
> be done in project.el if eglot-extend-to-xref is to be used.
...indeed you could stop at that.
Having the jars in project-external-roots could enable the users (after
certain integration work) to search across their contents with
project-or-external-find-regexp, or jump to files inside with
project-or-external-find-file.
But as for xref-find-definitions, item 4 in your list should be enough
(with either of the alternatives as underlying implementation).
next prev parent reply other threads:[~2022-10-29 1:22 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 21:44 bug#58790: Eglot URI parsing bug when using clojure-lsp server Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-26 6:22 ` Stefan Kangas
2022-10-26 19:50 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-27 15:09 ` João Távora
2022-10-29 1:22 ` Dmitry Gutov [this message]
2022-10-29 2:02 ` João Távora
2022-10-29 14:54 ` Dmitry Gutov
2022-10-29 19:35 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-31 14:40 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-02 8:09 ` João Távora
2022-11-02 13:15 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-03 17:10 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-10 9:49 ` Eli Zaretskii
2022-11-10 11:00 ` João Távora
2022-11-10 13:47 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-10 15:38 ` Eli Zaretskii
2022-11-10 21:45 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-10 21:59 ` João Távora
2022-11-10 22:22 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-10 22:30 ` João Távora
2022-11-10 22:48 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-10 22:48 ` João Távora
2022-11-10 22:57 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-11 7:29 ` Eli Zaretskii
2022-11-12 17:03 ` Michael Albinus
2022-11-13 21:04 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-15 19:04 ` Michael Albinus
2022-11-15 22:28 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-16 7:53 ` Michael Albinus
2022-11-16 10:21 ` João Távora
2022-11-16 15:45 ` Michael Albinus
2022-11-16 16:20 ` João Távora
2022-11-16 22:59 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-02 16:14 ` Michael Albinus
2022-12-07 18:56 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-08 13:46 ` Michael Albinus
2022-12-08 19:07 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-09 16:04 ` Michael Albinus
2022-12-10 17:21 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-10 17:45 ` Michael Albinus
2022-11-22 14:30 ` Michael Albinus
2022-11-23 11:55 ` Richard Copley
2022-11-23 12:36 ` João Távora
2022-11-23 12:42 ` Arash Esbati
2022-11-23 12:49 ` Richard Copley
2022-11-23 12:54 ` João Távora
2022-11-23 13:33 ` Eli Zaretskii
2022-11-23 13:44 ` João Távora
2022-11-23 14:03 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-23 19:53 ` João Távora
2022-11-11 8:30 ` Eli Zaretskii
2022-11-11 9:45 ` João Távora
2022-11-11 12:01 ` Eli Zaretskii
2022-11-11 14:02 ` João Távora
2022-11-11 14:45 ` Eli Zaretskii
2022-11-12 9:04 ` João Távora
2022-11-11 7:16 ` Eli Zaretskii
2022-11-01 17:25 ` Juri Linkov
2022-10-29 15:36 ` Felician Nemeth
2022-10-29 17:09 ` João Távora
2022-11-09 0:59 ` bug#58790: Robert Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f39bd6fa-903d-1723-8ec2-d7ffff4d4a9c@yandex.ru \
--to=dgutov@yandex.ru \
--cc=58790@debbugs.gnu.org \
--cc=danny@dfreeman.email \
--cc=joaotavora@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.