From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Date: Sat, 8 Oct 2022 21:50:39 +0300 Message-ID: References: <83h70qhez0.fsf@gnu.org> <83edvuhaby.fsf@gnu.org> <831qruh67o.fsf@gnu.org> <83y1u2foli.fsf@gnu.org> <83zgehe6iq.fsf@gnu.org> <95113379-99d8-eba4-f980-a7fca11430d5@yandex.ru> <834jwfmn5a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17970"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: gerd.moellmann@gmail.com, 58158@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 08 20:51:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohEup-0004Sd-VA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 20:51:15 +0200 Original-Received: from localhost ([::1]:56924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohEuo-0005Zs-LN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 14:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohEud-0005Z7-4K for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 14:51:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42372) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohEuc-0004Qn-9I for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 14:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohEub-0005Ya-Sw for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 14:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Oct 2022 18:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58158 X-GNU-PR-Package: emacs Original-Received: via spool by 58158-submit@debbugs.gnu.org id=B58158.166525505221339 (code B ref 58158); Sat, 08 Oct 2022 18:51:01 +0000 Original-Received: (at 58158) by debbugs.gnu.org; 8 Oct 2022 18:50:52 +0000 Original-Received: from localhost ([127.0.0.1]:41450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohEuR-0005Y7-JB for submit@debbugs.gnu.org; Sat, 08 Oct 2022 14:50:51 -0400 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:43645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohEuN-0005Xs-Nf for 58158@debbugs.gnu.org; Sat, 08 Oct 2022 14:50:50 -0400 Original-Received: by mail-wm1-f52.google.com with SMTP id r3-20020a05600c35c300b003b4b5f6c6bdso4234566wmq.2 for <58158@debbugs.gnu.org>; Sat, 08 Oct 2022 11:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=l8FXWyVSthpuYnVASERuOe43IyekO3Fz3D6bmwJbmdA=; b=J7tKEvQyF9ZU/5zdscye1TFxxafGy+Xak56D/xJH2wWAMEUAV551fGmyFrnhEaJ12o wOPPx9eraoD+iLFVV81MD4xHe8nUZZ8fhNopD8VP9ttuWuI0Xlz78BOzMWAoUlkqmJse VFPtomOCvodes/rqK4ZM0uDUctoaS/KaIsQRpQIq+mQGU1JuZStfMsGxhg0V4ro1+rkb Tsg9i+PKt7e8jbT0MgfAX6vYjKWYsvLibscoErnqyBek3+h5HctMjheL1lRCB6fLxIET Vx+EjuzFE53C2C5228+9tenYHlNfKipnDjh0uLzjXkrjRwHAM91CrkXolLLas4S+MOBX SpTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l8FXWyVSthpuYnVASERuOe43IyekO3Fz3D6bmwJbmdA=; b=e1NotDp7FZD+kcE1ykmkKKuJFQ5zfwIpGQqzobRDzxxtIaiGh5zmqrR4J+89MrcGkc OGnibu84z43mLrqJBt8Ja7EgEalxOwk769va5bKDMY5lX8NFZ9gMcJsybB4Uv4JKDtbq ucq3InDsLO/Mk/PVdWoBofRwizGJJcSoJ2hhn6E2kMoFYKDRo5CqqW7TGB9tm7d2Wwc7 fNDpf15P/ZdsSGsWM/1nOZcVQN92/SWp22SzsD7yL1LHQZkwo2N0h5hI8ENH0D5t9YRj oi92sMtDCnFfO+BuMlj3xwE2qyTDSa85XpwYkP68+UW0SBn2G8C6PHB3dFKWv4adX8Um E4cg== X-Gm-Message-State: ACrzQf07Hz5rv+hRgQ+G+bORDR63sDTzzbUg8lPN7mWAWPMBg/dQmeji lymSTeXEGdfzI5kuuiD/SM8= X-Google-Smtp-Source: AMsMyM7DtIWFyl8cRhmmAgh2ciu/UoV6l8SNZE8+7PtbxD9hU9TXY32epBbNrE5Z0lh4XdFtl2RWSg== X-Received: by 2002:a1c:7412:0:b0:3b4:7a81:e7e4 with SMTP id p18-20020a1c7412000000b003b47a81e7e4mr6828868wmc.15.1665255041782; Sat, 08 Oct 2022 11:50:41 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h7-20020a05600c350700b003b4868eb71bsm11802523wmq.25.2022.10.08.11.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Oct 2022 11:50:41 -0700 (PDT) Content-Language: en-US In-Reply-To: <834jwfmn5a.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244931 Archived-At: On 07.10.2022 22:47, Eli Zaretskii wrote: >> Date: Fri, 7 Oct 2022 01:36:17 +0300 >> Cc: 58158@debbugs.gnu.org, monnier@iro.umontreal.ca >> From: Dmitry Gutov >> >> On 30.09.2022 09:11, Eli Zaretskii wrote: >>> "M-x xref-query-replace-in-results RET" >> >> JFYI this command has the convenient binding 'r' in Xref output buffers. > > It also works only when invoked from the Xref buffer, right? Yep. But we also have commands like xref-find-references-and-replace and dired-do-find-regexp-and-replace. > Btw, what am I doing wrong below? > > emacs -Q > C-x C-f src/character.h RET > M-x visit-tags-table RET RET > M-. char_string RET > r whatever RET > > Unexpected result: "No suitable matches here". Huh? what did I miss? We can't replace over "find definition" matches: they are more abstract and don't contain the necessary information to perform the replacement (such as the length of a match, for instance). And such xrefs might navigate you to the beginning of the line, for example, rather than to the beginning of the name. But that makes sense, doesn't it? If replacing over "find definitions" results worked fine, in the end you would get a codebase where all declarations of a method 'foo' got renamed, but all callsites of it remain unchanged. That couldn't have been your intention, could it? The error message could use some improvement, I suppose, but I'm not sure how to make it better.