From: corwin@bru.st
To: 68919@debbugs.gnu.org
Subject: bug#68919: 30.0.50; etc/w32-feature.el: tests do not work under --batch
Date: Sat, 03 Feb 2024 21:41:34 -0600 [thread overview]
Message-ID: <f36c392d94c88e7a59dca47a57d63c27@bru.st> (raw)
In-Reply-To: <CAJf-WoQ3J=CgwAhutKcFODiq4Edt_GJnMf8OTQV52Bv5DNzdWw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
On 2024-02-03 21:37, Corwin Brust wrote:
>
> This currently fails because the harfbuzz test is ungated: it runs
> irrespective of whether a (graphical) display is attached. Once I
> receive a confirmation with this Bug# for the commit message, I'll
> send along a tiny patch to address this using `display-graphic-p'.
>
Patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-etc-w32-feature.el-harfbuzz-skip-unless-display-grap.patch --]
[-- Type: text/x-diff; name=0001-etc-w32-feature.el-harfbuzz-skip-unless-display-grap.patch, Size: 1059 bytes --]
From 65bc247c664793cb2c9a21aae396d98ef5a50238 Mon Sep 17 00:00:00 2001
From: Corwin Brust <corwin@bru.st>
Date: Sat, 3 Feb 2024 20:54:29 -0600
Subject: [PATCH] ; etc/w32-feature.el (harfbuzz): skip unless
display-graphic-p
This enable the tests to be used with batch (Bug#68919), e.g.
emacs.exe -l etc/w32-feature.el --batch -eval \
'(ert-run-tests-batch-and-exit)'
---
etc/w32-feature.el | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/etc/w32-feature.el b/etc/w32-feature.el
index 8d36e32e0fb..3bd818ea6ea 100644
--- a/etc/w32-feature.el
+++ b/etc/w32-feature.el
@@ -45,10 +45,12 @@ feature-optimization
(string-match-p "CFLAGS=-O2" system-configuration-options)))
(ert-deftest feature-harfbuzz ()
- (should
- (eq
- 'harfbuzz
- (car (frame-parameter nil 'font-backend)))))
+ (if (display-graphic-p)
+ (should
+ (eq
+ 'harfbuzz
+ (car (frame-parameter nil 'font-backend))))
+ (ert-skip "No graphic display")))
(ert-deftest feature-gnutls ()
(should (gnutls-available-p)))
--
2.36.1
next prev parent reply other threads:[~2024-02-04 3:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 3:37 bug#68919: 30.0.50; etc/w32-feature.el: tests do not work under --batch Corwin Brust
2024-02-04 3:41 ` corwin [this message]
2024-02-04 7:08 ` Eli Zaretskii
2024-02-04 15:25 ` Corwin Brust
2024-02-04 15:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f36c392d94c88e7a59dca47a57d63c27@bru.st \
--to=corwin@bru.st \
--cc=68919@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.