From: Gregory Heytings <gregory@heytings.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: John Wiegley <johnw@newartisans.com>,
Eli Zaretskii <eliz@gnu.org>,
arstoffel@gmail.com, Stefan Monnier <monnier@iro.umontreal.ca>,
59956@debbugs.gnu.org
Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation
Date: Wed, 21 Dec 2022 09:28:43 +0000 [thread overview]
Message-ID: <f3057d4a1d89a7027dc5@heytings.org> (raw)
In-Reply-To: <0d1eac42-1ea4-46d5-6236-eebfa75618ec@gmail.com>
>> Augusto and Jim, can you please try the attached patch and tell us if
>> it fixes the issue without introducing regressions?
>
> It works for me after a bit of testing, thanks. I don't see any
> regressions on the Eshell side of things, at least.
>
Thanks for your feedback!
>
> While it would be nice to have a way for Eshell to provide multiple
> forms of its arguments for completion (one for external commands that
> expect a flat list of strings, and another for Eshell commands), that
> seems like a lot more work that would probably be better spent
> elsewhere. (And a change like that would be too big for the release
> branch anyway.)
>
Indeed. There are two levels involved here: the pcomplete one and the
eshell one. The patch makes the pcomplete level more robust by ensuring
that, even if pcomplete-parse-arguments-function does not return strings
(which was an implicit assumption), pcomplete will continue to work. On
the eshell level, it would probably be better add a companion function to
eshell-complete-parse-arguments (which is used for
pcomplete-parse-arguments-function) that would return a proper string
representation of the expanded arguments, and to use it for
pcomplete-parse-arguments-function, instead of
eshell-complete-parse-arguments.
next prev parent reply other threads:[~2022-12-21 9:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 1:25 bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation Jim Porter
2022-12-11 7:44 ` Eli Zaretskii
2022-12-11 8:56 ` Augusto Stoffel
2022-12-11 15:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-12 22:21 ` Gregory Heytings
2022-12-12 22:37 ` Augusto Stoffel
2022-12-12 23:27 ` Gregory Heytings
2022-12-16 11:20 ` Augusto Stoffel
2022-12-16 6:09 ` Jim Porter
2022-12-16 14:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-16 14:28 ` Gregory Heytings
2022-12-19 0:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 1:19 ` Gregory Heytings
2022-12-19 2:15 ` Jim Porter
2022-12-19 3:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 15:00 ` Gregory Heytings
2022-12-19 16:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 22:22 ` Gregory Heytings
2022-12-21 6:32 ` Jim Porter
2022-12-21 9:28 ` Gregory Heytings [this message]
2022-12-29 22:02 ` Gregory Heytings
2022-12-19 10:31 ` Augusto Stoffel
2022-12-19 16:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 18:04 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3057d4a1d89a7027dc5@heytings.org \
--to=gregory@heytings.org \
--cc=59956@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=eliz@gnu.org \
--cc=johnw@newartisans.com \
--cc=jporterbugs@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.