From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#27986: 26.0.50; 'rename-file' can rename files without confirmation Date: Mon, 11 Sep 2017 09:45:48 -0700 Organization: UCLA Computer Science Department Message-ID: References: <61980dde-3d68-7200-e7f4-98f62e410060@cs.ucla.edu> <1002ee73-0ab5-409b-831f-0c283c322264@cs.ucla.edu> <83o9rignt6.fsf@gnu.org> <83d17whl72.fsf@gnu.org> <8e6de468-600c-4f2d-a21a-c2ff3a63d065@cs.ucla.edu> <83zib0g221.fsf@gnu.org> <2bb4b7ee-6bf9-df3d-5cd8-ae7992b9f2e7@cs.ucla.edu> <83wp64fdc4.fsf@gnu.org> <83valnfv9u.fsf@gnu.org> <7f0c12f6-57eb-63b9-c296-e062cbf0710c@cs.ucla.edu> <83o9rffqfp.fsf@gnu.org> <83efsbfmij.fsf@gnu.org> <83efs8dp4b.fsf@gnu.org> <2ff8e814-b75d-1c9f-a096-8ad644c01ccc@cs.ucla.edu> <8360cpthq9.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1505326680 9864 195.159.176.226 (13 Sep 2017 18:18:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Sep 2017 18:18:00 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 Cc: rms@gnu.org, johnw@gnu.org, p.stephani2@gmail.com, michael.albinus@gmx.de, monnier@IRO.UMontreal.CA, 27986@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 11 18:46:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drRqW-0006GZ-VS for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 18:46:05 +0200 Original-Received: from localhost ([::1]:59012 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drRqe-0006IE-Aw for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 12:46:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drRqY-0006Hl-4w for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:46:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drRqU-0008D9-Tv for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:46:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53398) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drRqU-0008Cy-QU for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drRqU-0008CI-He for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2017 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 27986-submit@debbugs.gnu.org id=B27986.150514835831499 (code B ref 27986); Mon, 11 Sep 2017 16:46:02 +0000 Original-Received: (at 27986) by debbugs.gnu.org; 11 Sep 2017 16:45:58 +0000 Original-Received: from localhost ([127.0.0.1]:33846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drRqO-0008By-TG for submit@debbugs.gnu.org; Mon, 11 Sep 2017 12:45:58 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drRqN-0008Bl-DK for 27986@debbugs.gnu.org; Mon, 11 Sep 2017 12:45:55 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BFAD4160CE4; Mon, 11 Sep 2017 09:45:49 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id v_55UqsCWmmP; Mon, 11 Sep 2017 09:45:49 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EAA0F160CC8; Mon, 11 Sep 2017 09:45:48 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JjnCBPkD3nAY; Mon, 11 Sep 2017 09:45:48 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CA8A316096F; Mon, 11 Sep 2017 09:45:48 -0700 (PDT) In-Reply-To: <8360cpthq9.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136912 On 09/11/2017 07:47 AM, Eli Zaretskii wrote: > do these changes modify interactive > behavior in incompatible ways? I thought we agreed to leave the > interactive behavior intact, and only change the non-interactive uses. > That wasn't my understanding. In our last email exchange about interactivity I proposed that Emacs prompt the user when the destination is not a directory name but happens to be a directory (see Bug#27986#97), but you were dubious about that (Bug#27986#100) so I left it alone. I normally use dired to rename files in Emacs, and dired's behavior hasn't changed as far as I can tell. Where there is a bit of a change is when using M-x rename-file directly. Here, in the typical case with file name completion there is still no difference, since names of destination directories are completed to have trailing /. However, if one uses "M-x rename-file foo RET and then laboriously types out the name of an existing directory /tmp/destination-dir without using completion and without trailing / before hitting RET, one will notice a difference: rename-file will now say "File /tmp/destination-dir already exists; rename to it anyway? (yes or no)" and if one types "yes" the rename will typically fail. So yes, this is a (noisy) incompatibility with previous usage. If you like I can go back and implement the suggestion in Bug#27986#97; this would be more-compatible with existing usage. I suggest leaving it alone, though, as things are simpler and easier to explain the way they are.