From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Sat, 1 Feb 2020 02:18:05 +0300 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="93747"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 01 00:19:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixfZF-000OKy-1K for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Feb 2020 00:19:17 +0100 Original-Received: from localhost ([::1]:60732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixfZE-0004Us-4D for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 18:19:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47426) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixfZ5-0004Um-K7 for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 18:19:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixfZ0-0002kO-P3 for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 18:19:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixfZ0-0002js-Lk for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 18:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixfZ0-0000FB-H4 for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 18:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 23:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.1580512694874 (code B ref 38992); Fri, 31 Jan 2020 23:19:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 31 Jan 2020 23:18:14 +0000 Original-Received: from localhost ([127.0.0.1]:38208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixfYE-0000E2-0b for submit@debbugs.gnu.org; Fri, 31 Jan 2020 18:18:14 -0500 Original-Received: from mail-lj1-f195.google.com ([209.85.208.195]:40317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixfYC-0000Dq-Um for 38992@debbugs.gnu.org; Fri, 31 Jan 2020 18:18:13 -0500 Original-Received: by mail-lj1-f195.google.com with SMTP id n18so8773448ljo.7 for <38992@debbugs.gnu.org>; Fri, 31 Jan 2020 15:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AkGFo/95YKtbHGeJ5M7ECBHv1mLfkCURPPDIDmYR0qk=; b=SlntUUvxk3lIz2dCpcaThWWobWl12Lkpro3kkBok0VDgBmuBmwJ+SoDN+gYWJa7M0A uVcPlHU+UV+gIgfogtetbg3lkSq/ofRUDqStGDrY0DdoofC8kNJnIadtYyKwS69ZjUqK 2mD1PB4dTvzGAmMGeFEPpl6whFUxH0HPFkUCybkz5iwavTvQsaFEy1KrIJpQL0GEw3aQ 2Ap702XKlfYd/1doS5TVcFeThrmVkEBBE76XD3Yj/vd9qRpGnc+nwtBwseH01Qw0bXGJ M5Gn/z6D2kuApcyeM2dwU0JlqceJk5rgSJ0HQGvmXcudZD01g9SnSSJId4jIp0mxwxGi ALmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AkGFo/95YKtbHGeJ5M7ECBHv1mLfkCURPPDIDmYR0qk=; b=Ky9Do/k6gb2Rt7r/oZHnh8g3qTXORPeuPPOaT8vifM0JItaOsaF2t6yF4fvcfMg6yK /jy9ZEcny4OPvPR0qIpfiBX2Fe1WQESkTnw7luIMBDyM0SlACXSYeHyTvK4JOuRh32WV XjH9lmu/sZAk8EfTR5Yk466i01BKhH2ksNymAQHWmBwGUj/7o8CVRTligp0Fmiry6QSr tLuebGoBOYMYVD+HzcV9c1JfBnrN0EKgn05fhf0i4i48TID7Skfw/Llm0UjBAdJpibVb rjNK8jRoAiJnobwSvTawBqjDfUpC4wox8WeZ2l0EnJLZwjSk2qJ6EkUrpnUMIQEcfIlj JqwQ== X-Gm-Message-State: APjAAAXExmcZfcUIfqy0KRaxkR0hgqeDPOtqmN0G3RXbN7MUlbCzrbpI 7xwuhGoI/bUmVrbG+FRwVmU= X-Google-Smtp-Source: APXvYqzI7s68sxeJc+DB/h/Xgg2VDkzQZorBU+b0BNZSgaW6bH5gzCsCqDanH9moIuD8UEvvAu+KYQ== X-Received: by 2002:a2e:9183:: with SMTP id f3mr7207551ljg.64.1580512686902; Fri, 31 Jan 2020 15:18:06 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id r10sm6266902ljk.9.2020.01.31.15.18.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jan 2020 15:18:05 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175534 Archived-At: On 24.01.2020 17:11, Stefan Monnier wrote: > It's arguably breaking compatibility. But you might be right that maybe > it's a non issue. A quick `grep` shows that outside Emacs itself, at > least Helm might be affected Speaking of Helm, there are only a few matches: https://github.com/emacs-helm/helm/search?q=minibuffer-completion-confirm&unscoped_q=minibuffer-completion-confirm And AFAICT it also binds minibuffer-completion-confirm to either t straight away or to the value of the must-match argument (as opposed to its reverse as we might expect). And here's some documentation of that usage: https://github.com/emacs-helm/helm/blob/75563d35a6ae62c669aba4b7bf02ed23b13f6de4/helm.el#L5617-L5623 Overall, it seems like it uses its variable for its own purpose (later comparing the value to t in a different function, for example), and it could just as well created a global variable solely for use in Helm. So it shouldn't be affected by the proposed changes. With that said, Eli, what do you think about the two patches I've sent to this bug earlier? I'd like them in emacs-27.