From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47960: 28.0.50; delete-by-moving-to-trash fails on directories? Date: Fri, 23 Apr 2021 20:39:20 +0000 Message-ID: References: <87mttq6o6n.fsf@protesilaos.com> <87bla66lp3.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="bh71MWLj8f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6824"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 47960@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 23 22:52:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1la2ml-0001dD-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Apr 2021 22:52:23 +0200 Original-Received: from localhost ([::1]:48054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1la2mk-0004RT-C9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Apr 2021 16:52:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la2ao-0005bq-OI for bug-gnu-emacs@gnu.org; Fri, 23 Apr 2021 16:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55698) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1la2ao-00085A-Dh for bug-gnu-emacs@gnu.org; Fri, 23 Apr 2021 16:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1la2ao-0007ra-Ao for bug-gnu-emacs@gnu.org; Fri, 23 Apr 2021 16:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Apr 2021 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47960 X-GNU-PR-Package: emacs Original-Received: via spool by 47960-submit@debbugs.gnu.org id=B47960.161921036430173 (code B ref 47960); Fri, 23 Apr 2021 20:40:02 +0000 Original-Received: (at 47960) by debbugs.gnu.org; 23 Apr 2021 20:39:24 +0000 Original-Received: from localhost ([127.0.0.1]:39011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la2aC-0007qa-F1 for submit@debbugs.gnu.org; Fri, 23 Apr 2021 16:39:24 -0400 Original-Received: from heytings.org ([95.142.160.155]:50588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la2a9-0007qR-Vz for 47960@debbugs.gnu.org; Fri, 23 Apr 2021 16:39:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1619210360; bh=Fsu3A19ZaxUTm5JyhPGwhH85tAolTJqITRKj2c5CF44=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=aANI0sgC0doORcAAPIJpONFHruADHigPg61Qug1aNyrCe4n9ofvG2AJ8sgTWtBexw sDGGEBP+l7I6Oj6vKmEIP0Lg2wQ6K5JMdQxu6FCj0UnjUNI5lOzwMRIB8Ook/RKf/z B6frlIQvfvyqy0VVRe7l7s5Ou+yn8GyQU4vpWNS+lDVdByMRouVTm023SwESYQdCQe MCxtFpVW/kt7ZFfGdDy2q5kGI8w5XOOZmsG5k/u+MIpohTtbAUKuu0aAkAGwgt2hN9 ziE/DGY9/GE129oVctk64HnlI9zGn03ImxyHDAFIBV8LHlSCVMYvb01JKedEMD7JkS n6wHdPYyyjosQ== In-Reply-To: <87bla66lp3.fsf@protesilaos.com> Content-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204760 Archived-At: --bh71MWLj8f Content-Type: text/plain; charset=us-ascii; format=flowed Content-ID: > > What seems to be the issue is when a deleted entry of the same name > already exists. I emptied my trash and tried the above recipe: the > problem would not occur. But upon immediate retry the problem appeared, > presumably because "test" already existed in the trash. > Indeed, this path of the code was recently changed (commit a5197e2240), and indeed, when a directory with the same name is trashed twice, it fails. Patch attached. (It can't be applied yet, I'm still waiting for the end of my paperwork.) --bh71MWLj8f Content-Type: text/x-diff; name=Fix-bug-when-moving-directories-to-trash.patch; charset=us-ascii Content-Transfer-Encoding: base64 Content-ID: Content-Description: Content-Disposition: attachment; filename=Fix-bug-when-moving-directories-to-trash.patch RnJvbSA2OGRlY2U4YzgxMDQ1YWFkOGM1ODk3NzdhN2RjNjZhN2UzOGU2Mzg1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBGcmksIDIzIEFw ciAyMDIxIDIwOjMyOjAyICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEZpeCBi dWcgd2hlbiBtb3ZpbmcgZGlyZWN0b3JpZXMgdG8gdHJhc2gNCg0KKiBsaXNw L2ZpbGVzLmVsIChtb3ZlLWZpbGUtdG8tdHJhc2gpOiBQYXNzIHRoZSBjb3Jy ZWN0IGRpci1mbGFnIHRvDQptYWtlLXRlbXAtZmlsZSBzbyB0aGF0IGEgZGly ZWN0b3J5IGlzIGNyZWF0ZWQgd2hlbiBhIGRpcmVjdG9yeSBpcw0KYmVpbmcg dHJhc2hlZCAoQnVnIzQ3OTYwKS4NCi0tLQ0KIGxpc3AvZmlsZXMuZWwgfCA0 ICsrKy0NCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlz cC9maWxlcy5lbA0KaW5kZXggNzQ0MGMxMWEyMS4uMjcyODJmMDlmYyAxMDA2 NDQNCi0tLSBhL2xpc3AvZmlsZXMuZWwNCisrKyBiL2xpc3AvZmlsZXMuZWwN CkBAIC03ODc4LDYgKzc4NzgsNyBAQCBtb3ZlLWZpbGUtdG8tdHJhc2gNCiAN CiAJICAgICAgIDs7IE1ha2UgYSAudHJhc2hpbmZvIGZpbGUuICBVc2UgT19F WENMLCBhcyBwZXIgdHJhc2gtc3BlYyAxLjAuDQogCSAgICAgICAobGV0KiAo KGZpbGVzLWJhc2UgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkgZm4pKQ0KKyAg ICAgICAgICAgICAgICAgICAgICAoaXMtZGlyZWN0b3J5IChmaWxlLWRpcmVj dG9yeS1wIGZuKSkNCiAgICAgICAgICAgICAgICAgICAgICAgKG92ZXJ3cml0 ZSBuaWwpDQogICAgICAgICAgICAgICAgICAgICAgIGluZm8tZm4pDQogICAg ICAgICAgICAgICAgICA7OyBXZSdyZSBjaGVja2luZyBmdXJ0aGVyIGRvd24g d2hldGhlciB0aGUgaW5mbyBmaWxlDQpAQCAtNzg4OSw3ICs3ODkwLDggQEAg bW92ZS1maWxlLXRvLXRyYXNoDQogICAgICAgICAgICAgICAgICAgICAgICAg IGZpbGVzLWJhc2UgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkNCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1ha2UtdGVtcC1maWxl DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZXhw YW5kLWZpbGUtbmFtZQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZpbGVzLWJhc2UgdHJhc2gtZmlsZXMtZGlyKSkpKSkNCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmaWxlcy1i YXNlIHRyYXNoLWZpbGVzLWRpcikNCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGlzLWRpcmVjdG9yeSkpKSkNCiAJCSAoc2V0cSBp bmZvLWZuIChleHBhbmQtZmlsZS1uYW1lDQogCQkJCShjb25jYXQgZmlsZXMt YmFzZSAiLnRyYXNoaW5mbyIpDQogCQkJCXRyYXNoLWluZm8tZGlyKSkNCi0t IA0KMi4zMC4yDQoNCg== --bh71MWLj8f--