all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Yasuhiro KIMURA <yasu@utahime.org>
Cc: 42841-done@debbugs.gnu.org
Subject: bug#42841: 28.0.50; [ruby-mode] ruby-{beginning,end}-of-block doesn't work as is exepected if arguments of method is divided into multi line
Date: Sat, 22 Aug 2020 16:30:04 +0300	[thread overview]
Message-ID: <f2b35d4a-47fb-c6c1-2342-9c2697ac2aae@yandex.ru> (raw)
In-Reply-To: <20200822.111703.1806179178749269056.yasu@utahime.org>

Version: 28.1

On 22.08.2020 05:17, Yasuhiro KIMURA wrote:
> From: Dmitry Gutov <dgutov@yandex.ru>
> Subject: Re: bug#42841: 28.0.50; [ruby-mode] ruby-{beginning,end}-of-block doesn't work as is exepected if arguments of method is divided into multi line
> Date: Sat, 22 Aug 2020 03:26:15 +0300
> 
>> I can't seem to reproduce this. Even after some intensive testing.
>>
>>> Wrong type argument: number-or-marker-p, nil
>>
>> Could you perhaps provide a backtrace?
>>
>> Type M-x toggle-debug-on-error, then trigger the error again.
> 
> I started emacs with '-Q' option and got following backtrace.
> 
> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
>    ruby-move-to-block(1)
>    ruby-end-of-block(1)
>    funcall-interactively(ruby-end-of-block 1)
>    call-interactively(ruby-end-of-block nil nil)
>    command-execute(ruby-end-of-block)

Oh, okay, I see it now. Couldn't reproduce it before because my config 
contains this line:

   (setq ruby-deep-indent-paren (delete ?\( ruby-deep-indent-paren))

Which logically shouldn't have any effect because we're not doing any 
indentation, but unfortunately does.

So I'm going to go ahead and try to fix it by removing the offending 
code. From some moderate testing, this doesn't seem to have any actual 
effect on indentation (the non-SMIE variant), and fixes the error. Let's 
see whether we get any breakage reports later.

Commit 2725254ab5.





  reply	other threads:[~2020-08-22 13:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13  7:17 bug#42841: 28.0.50; [ruby-mode] ruby-{beginning,end}-of-block doesn't work as is exepected if arguments of method is divided into multi line Yasuhiro KIMURA
2020-08-22  0:26 ` Dmitry Gutov
2020-08-22  2:17   ` Yasuhiro KIMURA
2020-08-22 13:30     ` Dmitry Gutov [this message]
2020-09-09  7:35       ` Yasuhiro KIMURA
2020-09-11 10:12         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2b35d4a-47fb-c6c1-2342-9c2697ac2aae@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=42841-done@debbugs.gnu.org \
    --cc=yasu@utahime.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.