From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function. Date: Wed, 30 Oct 2019 18:47:55 +0200 Message-ID: References: <20191030121649.15369.13207@vcs0.savannah.gnu.org> <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org> <87eeyutgwa.fsf@gnus.org> <333d1d46-ab79-5818-4367-b28ed915aff6@yandex.ru> <87a79itfzp.fsf@gnus.org> <875zk6tfo7.fsf@gnus.org> <60a85c88-dbec-1a9c-c9db-a74dec320ab6@yandex.ru> <87v9s6qkbn.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="192335"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 30 17:48:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPr8r-000nnG-I9 for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 17:48:22 +0100 Original-Received: from localhost ([::1]:42674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPr8p-0002zk-QB for ged-emacs-devel@m.gmane.org; Wed, 30 Oct 2019 12:48:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60428) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPr8f-0002vx-9M for emacs-devel@gnu.org; Wed, 30 Oct 2019 12:48:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPr8a-0003st-EM for emacs-devel@gnu.org; Wed, 30 Oct 2019 12:48:05 -0400 Original-Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:34167) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPr8a-0003ra-4L for emacs-devel@gnu.org; Wed, 30 Oct 2019 12:48:00 -0400 Original-Received: by mail-ed1-x52b.google.com with SMTP id b72so2325378edf.1 for ; Wed, 30 Oct 2019 09:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3yPoCeXIdBMRA39waiETrBwo7UOg14xwq3TV9+si8yI=; b=nKfrkzbrWvtbNA/clmo3u/9br31/d/qy6oRo0XfHfLzF2nv0TbxDYDghobcY/DEfRA 7roKJ/kbf/vW8Hm1x8/v2aSPYD1YFvKxgS/agUCFiUnygXRPo6k5LdmUZ4j8orpF3ugV /BlaO9BgVXpZpXNAwNFWD5C7tQpErB72zhU5dZBA6tWDQh3g8JhG4/guiGvYi5/IZlOh iOesTHXq+XMH1mhR5pS63dDlXcJe8GGYgJhjnBLAALWoIi3ldhg22c6G8G7HNabL9NMh hf+6GlYVtUtF11pt7QdTaqodCX4QPcubbxQTUAyhQjSoRt2JRhT+SfwceEHTPDqnyBak aE4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3yPoCeXIdBMRA39waiETrBwo7UOg14xwq3TV9+si8yI=; b=hQdDGHwk0WoYpyw4BvFF7PvvPi8EZNkF04nB6UG5TYpIayVOR5twcA00bDwbQmcVaa IWboi1JWgkC+SzkpYNUpQuTaotRnGVXmIlkWld7sTp2td0nxcP2jkY95poOBelvOZLiZ fb5zt3wkHWO4BLM8S3gLTciTzdq4o7G3i3ZJF1lI9lWlGEMbLIdb9N+Nz2U84cmMRDJj HUGcrq7nIr8EfTtd/gpXteHpinoCd6mSlJZdUsUGY5mwJxeUd5ze++vP5IpEeqy1PYRW NtN5dqzlLopIjvVl5M+y/t5Zq78nSyL31BCXkGLB8bzNJrkPZdT5dUAD0RTEGrTYdLiQ T9qg== X-Gm-Message-State: APjAAAXIjl/ENiMhSyix4x1yE0ZuWx1DhlpqkBdIveiOG8b13St8dKdj d3INea5X2F/BJsgdoyuX24sChBpeJqs= X-Google-Smtp-Source: APXvYqxWupNdAYkdRsls5kbNauFWFRKT1RkJi2pzl1SvA8NtXgo8vvpkrMKN9yVxZmZ70Qgl15CAvA== X-Received: by 2002:a05:6402:882:: with SMTP id e2mr646341edy.289.1572454078658; Wed, 30 Oct 2019 09:47:58 -0700 (PDT) Original-Received: from [192.168.0.140] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id s4sm13829edt.34.2019.10.30.09.47.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Oct 2019 09:47:57 -0700 (PDT) In-Reply-To: <87v9s6qkbn.fsf@gnus.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241638 Archived-At: On 30.10.2019 18:17, Lars Ingebrigtsen wrote: > Only the first of these is an accessor -- the other two look like > utility functions. OK, you are right. Regarding the names, some suggestions: ppss-after-quote-character -> -after-quote-p ppss-start-comment-or-string -> -comment-or-string-start ppss-internal -> nix ppss-start-last-complete-sexp and ppss-minimum-paren-depth can probably be nixed as well since "they can't be relied on". And prepend the names with syntax-, I think.