From: Phil Sainty <psainty@orcon.net.nz>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs-devel <emacs-devel-bounces+psainty=orcon.net.nz@gnu.org>,
emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] fix/bug-2034 21904f5: Support mode line constructs for 'mode-name' in c-mode (bug#2034)
Date: Wed, 04 Jul 2018 10:37:27 +1200 [thread overview]
Message-ID: <f237aeb4c982e0caa5ab2eeeba26b11b@webmail.orcon.net.nz> (raw)
In-Reply-To: <jwvpo04uj82.fsf-monnier+emacsdiffs@gnu.org>
On 2018-07-04 09:03, Stefan Monnier wrote:
> At that point, why use `format` here instead of using mode-line
> constructs for everything, as in:
>
> (setq c-mode-line-flags
> '("/"
> (c-block-comment-flag "*" "/")
> ...))
>
> Then c-update-modeline doesn't need to be called repeatedly since the
> refresh is done automatically by force-mode-line-update.
That's true. It would mean that a bit more work is happening per
modeline
render, vs only (I think?) calculating the flags when they change; but
assuming that's nothing to worry about, it sounds sensible to me too.
-Phil
next prev parent reply other threads:[~2018-07-03 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180703123449.18179.32328@vcs0.savannah.gnu.org>
[not found] ` <20180703123451.00E9320543@vcs0.savannah.gnu.org>
2018-07-03 21:03 ` [Emacs-diffs] fix/bug-2034 21904f5: Support mode line constructs for 'mode-name' in c-mode (bug#2034) Stefan Monnier
2018-07-03 22:37 ` Phil Sainty [this message]
2018-07-03 23:57 ` Phil Sainty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f237aeb4c982e0caa5ab2eeeba26b11b@webmail.orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=emacs-devel-bounces+psainty=orcon.net.nz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.