From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification Date: Mon, 28 Nov 2022 18:08:01 +0100 Message-ID: References: <729dcdf6-7cf7-3398-78d8-2b7ca1f2c005@secure.kjonigsen.net> <00b6627a-860b-f86c-06a9-5166da99a965@secure.kjonigsen.net> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------tNXHamhpEiTnD0iQd3Fimm0a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23441"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 To: 59660@debbugs.gnu.org, Theodor Thornhill , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 28 18:09:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozhd9-0005te-CS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Nov 2022 18:09:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozhcu-0007ey-Af; Mon, 28 Nov 2022 12:09:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozhcs-0007ce-EJ for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 12:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozhcs-0001h5-5C for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 12:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozhcr-0006Lv-Uy for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 12:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59660 X-GNU-PR-Package: emacs Original-Received: via spool by 59660-submit@debbugs.gnu.org id=B59660.166965529324412 (code B ref 59660); Mon, 28 Nov 2022 17:09:01 +0000 Original-Received: (at 59660) by debbugs.gnu.org; 28 Nov 2022 17:08:13 +0000 Original-Received: from localhost ([127.0.0.1]:49781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhc5-0006Lg-6I for submit@debbugs.gnu.org; Mon, 28 Nov 2022 12:08:13 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhc2-0006LY-LA for 59660@debbugs.gnu.org; Mon, 28 Nov 2022 12:08:11 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 35FB95C0162; Mon, 28 Nov 2022 12:08:04 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 28 Nov 2022 12:08:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1669655284; x=1669741684; bh=DhXAP3fxYySQK5UynzTb0kaBAb1ZEexFGvR xnj7JMhI=; b=S1UenPNVqeTggPIbOPfe78EQygIXYffqTlqyyAcvRGjtx0QB/IH uj8wmgF4j0lgR7mJ8vcTjkMNvrOaAbF+tFGFlZeBDysujM9QhtfpK/lDyOqosyye U5LyMke2i8GUs5oi4vihqlIr92zlxQTbfiy3Sp/+Dc0wY6o2GcIAd4EBMvnkkPBL OACucnCTIrNmlXWZxVwonFjUPKuX8IqDgQSTgVqtJVm8PDttJ/Zn5ju8Q9ODB+KU EX2/ioen57MRD7StGRGsIb6NmVdmk/fQG6elRll/Lkad1E6iS+y4MgNbHsn1EEqk aMWFTvxCzYVl0zMxWl8Xa0oXFqqapZlzLBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669655284; x=1669741684; bh=DhXAP3fxYySQK 5UynzTb0kaBAb1ZEexFGvRxnj7JMhI=; b=J3/LwtgZizpJLfDBbZ9frnxTopNXG pRv+4nXmcHmily0DLcBpvUoijFNrMzFIYHBb7erLPXWteU/Lm0tqC15wxkRWOoib 4TYeuDq2Q+n6wOSSbWA23jXi0VUOj81XZICM69sN3+84pO+AgagRyKLdAssBOHIv vbvCmDeezjayy/rSgK7YpAdHMEEpuM0UIraaXnhH2334qPxR45dmAmdbkZ9onlV8 6FpaFn3cizqcTq62FsxFnbGldPgUCsmVx14KixU5b6bFcy1F4FLaJ0hzhBX3yK6B nTwtVhk0cmDC2FNLcjrEDuIwGnFnHLk84u/kU8rwypLDZuQGaPwmgAmmw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjedvgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuhffvfhgjsehmtderredtfeejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeejieffffdtieduhffhgfelueetgeeg hffhtdfftdffudelveffgeekudffhfevieenucffohhmrghinhepkhhjnhhighhsvghnrd hnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehj ohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Nov 2022 12:08:03 -0500 (EST) Content-Language: nb-NO In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249329 Archived-At: This is a multi-part message in MIME format. --------------tNXHamhpEiTnD0iQd3Fimm0a Content-Type: multipart/alternative; boundary="------------CMBpQnzhaZVv2A7EeVtTvV9i" --------------CMBpQnzhaZVv2A7EeVtTvV9i Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit All fixes and one more squashed into the attached patch :) Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 28.11.2022 17:53, Jostein Kjønigsen wrote: > > And another improvement. > > -- > Kind regards > *Jostein Kjønigsen* > > jostein@kjonigsen.net 🍵 jostein@gmail.com > https://jostein.kjønigsen.no > On 28.11.2022 17:44, Jostein Kjønigsen wrote: >> >> This additional patch further improves fontification by fontifying >> function-arguments as variables too. >> >> -- >> >> Kind regards >> *Jostein Kjønigsen* >> >> jostein@kjonigsen.net 🍵 jostein@gmail.com >> https://jostein.kjønigsen.no >> On 28.11.2022 16:09, Jostein Kjønigsen wrote: >>> >>> Attached is a simple patch which addresses this font-lock issue and >>> makes typescript-ts-mode much better to use. >>> >>> -- >>> Kind regards >>> *Jostein Kjønigsen* >>> >>> jostein@kjonigsen.net 🍵 jostein@gmail.com >>> https://jostein.kjønigsen.no --------------CMBpQnzhaZVv2A7EeVtTvV9i Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

All fixes and one more squashed into the attached patch :)

On 28.11.2022 17:53, Jostein Kjønigsen wrote:

And another improvement.

On 28.11.2022 17:44, Jostein Kjønigsen wrote:

This additional patch further improves fontification by fontifying function-arguments as variables too.

--

On 28.11.2022 16:09, Jostein Kjønigsen wrote:

Attached is a simple patch which addresses this font-lock issue and makes typescript-ts-mode much better to use.

--------------CMBpQnzhaZVv2A7EeVtTvV9i-- --------------tNXHamhpEiTnD0iQd3Fimm0a Content-Type: text/x-patch; charset=UTF-8; name="0004-lisp-progmodes-typescript-ts-mode.el-fontification-i.patch" Content-Disposition: attachment; filename*0="0004-lisp-progmodes-typescript-ts-mode.el-fontification-i.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4MTYyZmViNTYxYWI4NzM4NjBhY2NmMTllNmQzODRkMTljYTBmY2MzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogTW9uLCAyOCBOb3YgMjAyMiAx NjowNToyNyArMDEwMApTdWJqZWN0OiBbUEFUQ0ggNC80XSBsaXNwL3Byb2dtb2Rlcy90eXBl c2NyaXB0LXRzLW1vZGUuZWw6IGZvbnRpZmljYXRpb24KIGltcHJvdmVtZW50cwoKLSByZXN0 b3JlIG1ldGhvZC1uYW1lIGZvbnRpZmljYXRpb24uCi0gZm9udGlmeSBhbGwgdHlwZXMgaW4g Y2xhc3MtZGVjbGFyYXRpb25zLCBleHRlbmRlZXMgdG9vCi0tLQogbGlzcC9wcm9nbW9kZXMv dHlwZXNjcmlwdC10cy1tb2RlLmVsIHwgMTIgKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdl ZCwgOSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av cHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL3R5cGVz Y3JpcHQtdHMtbW9kZS5lbAppbmRleCBiZjQ4M2EzMWQzNC4uNmM5MjZhNGUzZTAgMTAwNjQ0 Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbAorKysgYi9saXNw L3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKQEAgLTE1MCwxMiArMTUwLDIwIEBA IHR5cGVzY3JpcHQtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAKICAgICAgKG1ldGhv ZF9kZWZpbml0aW9uCiAgICAgICBuYW1lOiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQt bG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCisgICAgIChyZXF1aXJlZF9wYXJhbWV0ZXIgKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorICAgICAob3B0aW9u YWxfcGFyYW1ldGVyIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFj ZSkKIAogICAgICAodmFyaWFibGVfZGVjbGFyYXRvcgogICAgICAgbmFtZTogKGlkZW50aWZp ZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogCiAgICAgIChlbnVtX2RlY2xh cmF0aW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKIAorICAgICAoZXh0 ZW5kc19jbGF1c2UgdmFsdWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkK KyAgICAgOzsgZXh0ZW5kcyBSZWFjdC5Db21wb25lbnQ8VD4KKyAgICAgKGV4dGVuZHNfY2xh dXNlIHZhbHVlOiAobWVtYmVyX2V4cHJlc3Npb24KKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgb2JqZWN0OiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcHJvcGVydHk6IChwcm9wZXJ0eV9pZGVudGlmaWVy KSBAZm9udC1sb2NrLXR5cGUtZmFjZSkpCisKICAgICAgKGFycm93X2Z1bmN0aW9uCiAgICAg ICBwYXJhbWV0ZXI6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFj ZSkKIApAQCAtMjY3LDkgKzI3NSw3IEBAIHR5cGVzY3JpcHQtdHMtbW9kZS0tZm9udC1sb2Nr LXNldHRpbmdzCiAgICA6bGFuZ3VhZ2UgJ3RzeAogICAgOm92ZXJyaWRlIHQKICAgIDpmZWF0 dXJlICdwcm9wZXJ0eQotICAgYCgoKHByb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2st cHJvcGVydHktZmFjZSkKLQotICAgICAocGFpciB2YWx1ZTogKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorICAgYCgocGFpciB2YWx1ZTogKGlkZW50aWZp ZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogCiAgICAgICgoc2hvcnRoYW5k X3Byb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2stcHJvcGVydHktZmFjZSkKIAotLSAK Mi4zNy4yCgo= --------------tNXHamhpEiTnD0iQd3Fimm0a--