From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: wbe@psr.com, 28439@debbugs.gnu.org
Subject: bug#28439: suggestion: support case-independent xref-find-definitions prompt TAB
Date: Tue, 19 Sep 2017 03:55:34 +0300 [thread overview]
Message-ID: <f200d462-c769-a1ca-7319-8107eb0abf16@yandex.ru> (raw)
In-Reply-To: <83377pnrin.fsf@gnu.org>
On 9/14/17 8:01 PM, Eli Zaretskii wrote:
>> Sorry, what don't we want to follow the value of completion-ignore-case?
>
> Because it has a much broader effect.
I guessed so. But do you have a particular problem in mind?
> And because the issue here is
> inconsistency between completion and actual matching in
> xref-find-definitions. They should be consistent, IMO.
I think I agree, because xref--read-identifier calls completing-read
with nil require-match argument (so we can't rely on the completion
table to correct the input), but your patch doesn't fix the
inconsistency. It only moves the identifier read toward the
case-fold-search default.
>> The fact that we have the option tags-case-fold-search (used in
>> find-tag-tag, among other places) probably means that some users prefer
>> not to ignore case.
>
> Then maybe an alternative is to make tags-case-fold-search nil by
> default? Or make xref--read-identifier be case-insensitive if
> case-fold-search is non-nil?
The other way around: etags--xref-find-definitions can bind
tags-case-fold-search to the value of completion-ignore-case. Or
whichever xref-specific variable we add.
We'd also need to add case-insensitive search support to
elisp--xref-find-definitions, I suppose. So far,
find-function-search-for-symbol always performs case-sensitive search.
It's rarely a problem, though, because Elisp uses capital letters very
infrequently.
>> Maybe we could add a similar xref-specific option on top, but I'm not
>> sure why completion-ignore-case is not good enough.
>>
>> We could change its default to t, though.
>
> Emacs-wide? Or just when completing on identifiers?
Either is fine, as far as I'm concerned.
next prev parent reply other threads:[~2017-09-19 0:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 22:37 bug#28439: suggestion: support case-independent xref-find-definitions prompt TAB Winston
2017-09-12 23:24 ` Stephen Berman
2017-09-12 23:31 ` bug#28439: suggestion: support case-independent xref-find-definitions Winston
2017-09-13 15:30 ` bug#28439: suggestion: support case-independent xref-find-definitions prompt TAB Eli Zaretskii
2017-09-13 23:04 ` Dmitry Gutov
2017-09-14 17:01 ` Eli Zaretskii
2017-09-19 0:55 ` Dmitry Gutov [this message]
2017-09-19 4:01 ` Eli Zaretskii
2017-09-14 18:21 ` bug#28439: suggestion: support case-independent xref-find-definitions prompt Winston
2017-09-14 22:05 ` Dmitry Gutov
2017-09-14 22:33 ` bug#28439: suggestion: support case-independent Winston
2017-09-19 0:41 ` Dmitry Gutov
2017-09-27 23:07 ` bug#28439: suggestion: support case-independent xref-find-definitions prompt Winston
2017-09-28 20:47 ` Dmitry Gutov
2020-09-15 15:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f200d462-c769-a1ca-7319-8107eb0abf16@yandex.ru \
--to=dgutov@yandex.ru \
--cc=28439@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=wbe@psr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.