From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#24206: 25.1; Curly quotes generate invalid strings, leading to a segfault Date: Sat, 13 Aug 2016 23:54:43 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------8FA4D93C2958716CD26FD1B2" X-Trace: blaine.gmane.org 1471150522 6230 195.159.176.226 (14 Aug 2016 04:55:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 14 Aug 2016 04:55:22 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Cc: John Wiegley , Nicolas Petton , 24206-done@debbugs.gnu.org To: Phil Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 14 06:55:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYnSA-0001S2-Al for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Aug 2016 06:55:18 +0200 Original-Received: from localhost ([::1]:59583 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYnS7-00064b-6c for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Aug 2016 00:55:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYnRx-0005zt-7j for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 00:55:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYnRv-00052X-AS for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 00:55:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYnRv-00052P-79 for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 00:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bYnRu-0008DC-Iq for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 00:55:02 -0400 In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2016 04:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 24206@debbugs.gnu.org, eggert@cs.ucla.edu, p.stephani2@gmail.com Original-Received: via spool by 24206-done@debbugs.gnu.org id=D24206.147115050031553 (code D ref 24206); Sun, 14 Aug 2016 04:55:02 +0000 Original-Received: (at 24206-done) by debbugs.gnu.org; 14 Aug 2016 04:55:00 +0000 Original-Received: from localhost ([127.0.0.1]:56713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYnRs-0008Cr-Mu for submit@debbugs.gnu.org; Sun, 14 Aug 2016 00:55:00 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYnRq-0008Cd-Te for 24206-done@debbugs.gnu.org; Sun, 14 Aug 2016 00:54:59 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EC3231610DB; Sat, 13 Aug 2016 21:54:52 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Sg4ULxhzDFoX; Sat, 13 Aug 2016 21:54:52 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E68FD16121E; Sat, 13 Aug 2016 21:54:51 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id eDN3Hk14a3zA; Sat, 13 Aug 2016 21:54:51 -0700 (PDT) Original-Received: from [192.168.4.53] (ip-64-134-48-64.public.wayport.net [64.134.48.64]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 2BDAD1610DB; Sat, 13 Aug 2016 21:54:51 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122192 Archived-At: This is a multi-part message in MIME format. --------------8FA4D93C2958716CD26FD1B2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks forreporting that, Phil. Ituncovered several bugs in substitute-command-keys,some predating the curved-quote changes in Emacs 25. I installed a patch into Emacs master as commit 2791580f5eaa65948a13ea4ea4952d03b4da795b and am closing the bug as fixed. For Emacs 25 I propose installing the attached patch, which should avoid the emacs-goodies-el problem though it does not fix the other (presumably less-likely) bugs in this area. This patch is considerably simpler than what I just installed into master. --------------8FA4D93C2958716CD26FD1B2 Content-Type: text/x-patch; name="0001-Fix-core-dump-with-unibyte-substitute-command-keys.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Fix-core-dump-with-unibyte-substitute-command-keys.patc"; filename*1="h" >From 2cbfb2adb97b086e24c05b24ebf6349a3b3b94c9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 13 Aug 2016 23:38:33 -0500 Subject: [PATCH] Fix core dump with unibyte substitute-command-keys * src/doc.c (Fsubstitute_command_keys): Convert string to multibyte first (Bug#24206). Do not merge to master. --- src/doc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/doc.c b/src/doc.c index 7cdb0d0..f664e0e 100644 --- a/src/doc.c +++ b/src/doc.c @@ -757,6 +757,7 @@ Otherwise, return a new string. */) return Qnil; CHECK_STRING (string); + string = Fstring_make_multibyte (string); tem = Qnil; keymap = Qnil; name = Qnil; -- 2.5.5 --------------8FA4D93C2958716CD26FD1B2--