From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ravi Desai Newsgroups: gmane.emacs.devel Subject: EMACS_INT to EMACS_UINT Date: Sun, 4 Dec 2016 18:16:17 -0500 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1480893422 4557 195.159.176.226 (4 Dec 2016 23:17:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Dec 2016 23:17:02 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 05 00:16:59 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDg1g-0000Z5-Mv for ged-emacs-devel@m.gmane.org; Mon, 05 Dec 2016 00:16:56 +0100 Original-Received: from localhost ([::1]:36017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDg1k-0006fo-Jm for ged-emacs-devel@m.gmane.org; Sun, 04 Dec 2016 18:17:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDg1C-0006cm-KS for emacs-devel@gnu.org; Sun, 04 Dec 2016 18:16:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDg17-0003PO-Jn for emacs-devel@gnu.org; Sun, 04 Dec 2016 18:16:26 -0500 Original-Received: from mail-io0-x234.google.com ([2607:f8b0:4001:c06::234]:36847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cDg17-0003PG-Dz for emacs-devel@gnu.org; Sun, 04 Dec 2016 18:16:21 -0500 Original-Received: by mail-io0-x234.google.com with SMTP id m5so431678186ioe.3 for ; Sun, 04 Dec 2016 15:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravidesai-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=BCWLwgea6k+2ClB22llPjkrKj86WOzlq+XoySzPVCyE=; b=BCX+EZbUgyS7p33SAviAw6a6gRqmOthRFkwNGWuuWfxJ/gX2NEBocQNE3uKue+HRDl cQ+mWgao/RAyHXOGvbQwmOvwQGtChEjhU1DEAHz+vhcQuEm0dF30ZRf6MdD/rfWtpU93 0TqzdwyRTPvrHm33MZxAOpzYNQVtD2WHWd4cTsO4xyfadx+/Y0A2jWnSyl/aJUYPGoUw c3dGhwwGRkS1RB37VJyK0DOPNliVALswgINWsD1s7VAJKtwgGC/t6jSsK5SSpNPMA4QM Yp7IIctHm+ZdRZEd/by1k6IR/3YP6Bajkzu9aQ0w4TTXWEIaUfRjZKdJZ+iVrWFhFk2l jnuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=BCWLwgea6k+2ClB22llPjkrKj86WOzlq+XoySzPVCyE=; b=W9i58Ssw5iqbLeOkVcYEVO/eM2qM/k3IMvy2FnVy7DHGA+17FzAsE3YJAKSnNjPSzf BJUPrCoWIulps30Vij4tmlTes9RYmphLd5ArmnqVny+PaAtrViMsTaA+nxzxouBLr3N6 ZuT3dt8ZY9ZbfyKJ2y5z4Ru+ZToQG8xxew8ZKbY4UFYYV0H7EAY0S9lZLJbzIwCO2Lih lreyvd5QcA+EycGKJZ4PXV0Q67PNZHnO4rt+AxLcAWJ1hbDo9JOS4yAGqNiQpsKDj89S tVzD+nBAO2mpd1cs4zZCZ4f4t/ODPPcTLIQ6BThX204ChdBomg2RU1+jDufiHByBT0ig xSmQ== X-Gm-Message-State: AKaTC00ie1OaKcKUK8gRZifOricjzgiDNl4C8WkExxeaTpJ7MCmPZDLJ72HyGETcJToKYg== X-Received: by 10.36.36.146 with SMTP id f140mr6366743ita.75.1480893378302; Sun, 04 Dec 2016 15:16:18 -0800 (PST) Original-Received: from [192.168.0.101] (24-52-220-47.cable.teksavvy.com. [24.52.220.47]) by smtp.googlemail.com with ESMTPSA id 9sm6135807itv.0.2016.12.04.15.16.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Dec 2016 15:16:17 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c06::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210042 Archived-At: Hello all, I've been trying to familiarize myself with the emacs source at the C-level, and while I was looking at src/lisp.h I noticed that while 'XLI (a)' should return an EMACS_INT, we expect it to be a EMACS_UINT in the definition of 'XTYPE'. --- /* Extract A's type. */ INLINE enum Lisp_Type XTYPE (Lisp_Object a) { EMACS_UINT i = XLI (a); // <---- This seems strange to me. return USE_LSB_TAG ? i & ~VALMASK : i >> VALBITS; } --- Is this something that we should change? The code is working, so I don't know if its a big enough deal.