bug#34789: mantemp.el should be obsoleted

bug#34789: mantemp.el should be obsoleted

[Paul Eggert]

Davis Herring writes, "One of your fixes was to progmodes/mantemp.el,
which (now that I know it exists) I'm pretty sure should be obsoleted;
as you may already know, C++ compilers haven't worked that way for any
standard library type (and most user-defined types) in a very long time."

I notice that no significant changes have been made to mantemp.el since
1997. As it's evidently useless nowadays, I propose that we move
mantemp.el to the obsolete area, and remove it in a later Emacs release.

bug#34789: mantemp.el should be obsoleted

[Eli Zaretskii]

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 8 Mar 2019 11:16:27 -0800
> 
> Davis Herring writes, "One of your fixes was to progmodes/mantemp.el,
> which (now that I know it exists) I'm pretty sure should be obsoleted;
> as you may already know, C++ compilers haven't worked that way for any
> standard library type (and most user-defined types) in a very long time."
> 
> I notice that no significant changes have been made to mantemp.el since
> 1997. As it's evidently useless nowadays, I propose that we move
> mantemp.el to the obsolete area, and remove it in a later Emacs release.

If no compiler can ever be helped by that feature, I think I agree.
But I'd like first to hear in more detail why "C++ compilers haven't
worked that way for any standard library type (and most user-defined
types) in a very long time."  We should at least have this information
recorded here for posterity.

Thanks.

bug#34789: Scan of regexp mistakes

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:
> Thanks, it does.  I think we indeed should move this package into
> obsolete/.

Does this patch do the job?

Thanks,
Stefan Kangas

[-- Attachment #2: 0001-lisp-progmodes-mantemp.el-Move-to-obsolete-.-bug-347.patch --]
[-- Type: application/octet-stream, Size: 1620 bytes --]

From 34699af2c639d77de9a09320c20f798131b741f6 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Thu, 13 Jun 2019 14:07:12 +0200
Subject: [PATCH] * lisp/progmodes/mantemp.el: Move to obsolete/. (bug#34789)

---
 etc/NEWS                                | 5 +++++
 lisp/{progmodes => obsolete}/mantemp.el | 4 ++++
 2 files changed, 9 insertions(+)
 rename lisp/{progmodes => obsolete}/mantemp.el (98%)

diff --git a/etc/NEWS b/etc/NEWS
index 6efa7642f8..4bdd67f177 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1524,6 +1524,11 @@ buffer periodically when 'auto-revert-avoid-polling' is non-nil.
 *** 'bookmark-old-default-file' is now an obsolete alias of
 'bookmark-default-file'.
 
+---
+** The mantemp.el library is now marked obsolete.
+It should no longer be useful on modern C++ compilers, which do the
+same things automatically.
+
 \f
 * New Modes and Packages in Emacs 27.1
 
diff --git a/lisp/progmodes/mantemp.el b/lisp/obsolete/mantemp.el
similarity index 98%
rename from lisp/progmodes/mantemp.el
rename to lisp/obsolete/mantemp.el
index 4190a84727..9c2bdc09d0 100644
--- a/lisp/progmodes/mantemp.el
+++ b/lisp/obsolete/mantemp.el
@@ -5,6 +5,7 @@
 ;; Author: Tom Houlder <thoulder@icor.fr>
 ;; Created: 10 Dec 1996
 ;; Keywords: g++, templates
+;; Obsolete-since: 27.1
 
 ;; This file is part of GNU Emacs.
 
@@ -82,6 +83,9 @@
 ;; messages after the first instantiations have been included and you
 ;; must repeat the operation.
 
+;; For more information on why this was marked obsolete, see:
+;; https://debbugs.gnu.org/34789
+
 ;;; Code:
 
 (defun mantemp-remove-comments ()
-- 
2.21.0

bug#34789: Scan of regexp mistakes

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 13 Jun 2019 14:13:45 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, Davis Herring <herring@lanl.gov>
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> > Thanks, it does.  I think we indeed should move this package into
> > obsolete/.
> 
> Does this patch do the job?

Works for me, but I'm not sure we have the procedure for obsoleting a
package documented anywhere, so maybe something else needs to be
done.  Anyone?

bug#34789: Scan of regexp mistakes

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:
> > > Thanks, it does.  I think we indeed should move this package into
> > > obsolete/.
> >
> > Does this patch do the job?
>
> Works for me, but I'm not sure we have the procedure for obsoleting a
> package documented anywhere, so maybe something else needs to be
> done.  Anyone?

I had a look at this:
https://git.savannah.gnu.org/gitweb/?p=emacs.git;a=commit;h=ef65424de8cae00209f6a0974245822602709df3

And did some improvements, see attached patch.

Thanks,
Stefan Kangas

[-- Attachment #2: 0001-Move-mantemp.el-to-obsolete.patch --]
[-- Type: application/octet-stream, Size: 3024 bytes --]

From 37373dd44ede4fd097df022aa78e2b3aa93d9774 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Thu, 13 Jun 2019 14:07:12 +0200
Subject: [PATCH] Move mantemp.el to obsolete/

* lisp/progmodes/mantemp.el: Move to obsolete/. (bug#34789)
* doc/emacs/ack.texi (Acknowledgments): Remove obsolete library
mantemp.el.
---
 doc/emacs/ack.texi                      | 4 ----
 etc/NEWS                                | 5 +++++
 etc/TODO                                | 5 ++---
 lisp/{progmodes => obsolete}/mantemp.el | 4 ++++
 4 files changed, 11 insertions(+), 7 deletions(-)
 rename lisp/{progmodes => obsolete}/mantemp.el (98%)

diff --git a/doc/emacs/ack.texi b/doc/emacs/ack.texi
index 0e4a982da4..06e75f3077 100644
--- a/doc/emacs/ack.texi
+++ b/doc/emacs/ack.texi
@@ -502,10 +502,6 @@ Acknowledgments
 Tassilo Horn wrote DocView mode, allowing viewing of PDF, PostScript and
 DVI documents.
 
-@item
-Tom Houlder wrote @file{mantemp.el}, which generates manual C@t{++}
-template instantiations.
-
 @item
 Joakim Hove wrote @file{html2text.el}, a html to plain text converter.
 
diff --git a/etc/NEWS b/etc/NEWS
index 5632ccc6d7..7dc0764c60 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1524,6 +1524,11 @@ buffer periodically when 'auto-revert-avoid-polling' is non-nil.
 *** 'bookmark-old-default-file' is now an obsolete alias of
 'bookmark-default-file'.
 
+---
+** The mantemp.el library is now marked obsolete.
+This library generates manual C++ template instantiations.  It should
+no longer be useful on modern compilers, which do this automatically.
+
 \f
 * New Modes and Packages in Emacs 27.1
 
diff --git a/etc/TODO b/etc/TODO
index f8c2d285ee..273455c386 100644
--- a/etc/TODO
+++ b/etc/TODO
@@ -560,9 +560,8 @@ from the emacsclient process.
   snmp-mode [?], soundex [should be interactive?], strokes [start from
   the web page], talk, thingatpt [interactive functions?], type-break,
   vcursor, xscheme, zone-mode [?], mlconvert [?], iso-cvt,
-  feedmail [?], uce, gametree, page-ext,
-  refbib, refer, scribe, texinfo, underline,
-  cmacexp, hideif, mantemp [obsolete?], pcomplete, xml,
+  feedmail [?], uce, gametree, page-ext, refbib, refer, scribe,
+  texinfo, underline, cmacexp, hideif, pcomplete, xml,
   cvs-status (should be described in PCL-CVS manual); other progmodes,
   probably in separate manual.
 
diff --git a/lisp/progmodes/mantemp.el b/lisp/obsolete/mantemp.el
similarity index 98%
rename from lisp/progmodes/mantemp.el
rename to lisp/obsolete/mantemp.el
index 4190a84727..ad638422c2 100644
--- a/lisp/progmodes/mantemp.el
+++ b/lisp/obsolete/mantemp.el
@@ -5,6 +5,7 @@
 ;; Author: Tom Houlder <thoulder@icor.fr>
 ;; Created: 10 Dec 1996
 ;; Keywords: g++, templates
+;; Obsolete-since: 27.1
 
 ;; This file is part of GNU Emacs.
 
@@ -23,6 +24,9 @@
 
 ;;; Commentary:
 
+;; This file is obsolete.  For more information, see:
+;; https://debbugs.gnu.org/34789
+
 ;; The following is a typical error message from g++ using STL (here
 ;; with split lines):
 ;;
-- 
2.21.0

bug#34789: Scan of regexp mistakes

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 13 Jun 2019 15:42:40 +0200
> Cc: 34789@debbugs.gnu.org, Davis Herring <herring@lanl.gov>
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> > > > Thanks, it does.  I think we indeed should move this package into
> > > > obsolete/.
> > >
> > > Does this patch do the job?
> >
> > Works for me, but I'm not sure we have the procedure for obsoleting a
> > package documented anywhere, so maybe something else needs to be
> > done.  Anyone?
> 
> I had a look at this:
> https://git.savannah.gnu.org/gitweb/?p=emacs.git;a=commit;h=ef65424de8cae00209f6a0974245822602709df3
> 
> And did some improvements, see attached patch.

Thanks, pushed.