From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#35564: 27.0.50; [PATCH] Tweak dired-do-shell-command warning about "wildcard" characters Date: Wed, 8 May 2019 15:39:56 -0700 (PDT) Message-ID: References: <87zho2cd4f.fsf@gmail.com> <071cc96c-1bf2-f331-8f9e-b3c54a7452da@gmx.at> <877eb3e5im.fsf@gmail.com> <9bd289fe-3623-4c45-4c4f-04c6668cae76@gmx.at> <9fc1129c-5377-4b56-ba6d-dce497140941@default> <877eb0ptiy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149040"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35564@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 09 00:41:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOVFP-000cfI-Fa for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 May 2019 00:41:11 +0200 Original-Received: from localhost ([127.0.0.1]:44649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOVFO-0004v3-Fo for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 18:41:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOVFI-0004sB-4Y for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 18:41:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOVFG-0006Gh-66 for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 18:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48933) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOVFF-0006Fq-QL for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 18:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOVFF-0002TT-M4 for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 18:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 22:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.15573552079442 (code B ref 35564); Wed, 08 May 2019 22:41:01 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 8 May 2019 22:40:07 +0000 Original-Received: from localhost ([127.0.0.1]:34244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOVEN-0002SB-1V for submit@debbugs.gnu.org; Wed, 08 May 2019 18:40:07 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:44018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOVEL-0002Rd-Q7 for 35564@debbugs.gnu.org; Wed, 08 May 2019 18:40:06 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x48Mdgd8058753; Wed, 8 May 2019 22:40:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=M+BonKoczVdH8maEvqLDCQbii9+PdXZzjAfujKHEMdw=; b=b5Kjvk7XxIdjXFXlQAadCkkyi6byzaydu533JDUsauTguU8uA+R9eZfMUQpeIC2Mbs4x xKjggR1ddIoExz2UyUY5cOtoHcuNk27SJcmvZ2eg1qN2jThzjnPlmhUcBr3dLKBVkQT1 kDBEKzGrbLr7SuM4MW7JnSgTVfjj+d4jA/hAT6DPa+XZK45ngpkMe4kIlpgxkOMuNQNI UOtJul7tN96KgWujiCYYGgXImW4vvuAVHapGxyBCgbej7UTk45D2iCUWbbpxn1aMllfv H6Eqc4pBQGc6zxPqC/oUzmEIV05gtVTPUgkGxSkQOgukLOEwLU+Mk8+UGQJkS0X6KbmR 3w== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 2s94b67av8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 08 May 2019 22:39:59 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x48Mdw3a092858; Wed, 8 May 2019 22:39:59 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2sagyuw67d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 08 May 2019 22:39:59 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x48MdvwI029603; Wed, 8 May 2019 22:39:57 GMT In-Reply-To: <877eb0ptiy.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9251 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905080134 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9251 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905080135 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158963 Archived-At: > Drew Adams writes: >=20 > > I don't see any good reason why face `minibuffer-prompt' > > should be used, especially by default (users can do > > whatever they like) for situations where there is no > > active minibuffer, i.e., for prompting situations > > generally. It should instead serve as a useful clue > > that the minibuffer is being used. (Just one opinion.) >=20 > I'd hazard a guess[1] that this was done to make y-or-n-p and > yes-or-no-p similar from a UI point of view: they both prompt the user > for a binary answer, therefore the prompt might as well look the same in > both situations. >=20 > From what I can tell the use of 'minibuffer-prompt' in minibuffer-less > situations has enough precedents (the "other clients" Martin mentions) > that the "minibuffer-" prefix might be considered a historical accident > by now=E2=80=A6 Not an accident. The "precedents" are themselves bugs, IMO. The minibuffer is the minibuffer. It's important that users be aware when it is active. That may not matter much for `yes-or-no-p', as it insists on "yes" or "no". But it is important for the minibuffer in general. The minibuffer is an editing buffer; you can do lots of things in it and with it. > (Perhaps those clients could be migrated to a new face, > e.g. 'message-prompt', which would inherit 'minibuffer-prompt' by > default?) That would be fine by me. Or no face. Is it really important that the prompt be distinguished by a face? (To be clear, I have no objection to our using faces for prompts.) > - In the context of bug#35564, I would like to add text properties to > the y-or-n-p prompt (although I'm open to other, simpler solutions > e.g. simply changing Dired's message). I wouldn't mention bug #35564. And that bug should not, itself, also deal with prompt faces. It should be only about `dired-do-shell-command' warning about wildcard characters. Any question (for this command or in general) about prompt faces is independent of this bug report about the `dired-do-shell-command' treatment of wildcards. (Just one opinion.)