From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: When should ralloc.c be used? Date: Mon, 24 Oct 2016 09:54:24 -0700 Organization: UCLA Computer Science Department Message-ID: References: <87eg3rvtsf.fsf@users.sourceforge.net> <83k2dihpm9.fsf@gnu.org> <8760p2wzgj.fsf@users.sourceforge.net> <838ttyhhzu.fsf@gnu.org> <871szqwu51.fsf@users.sourceforge.net> <831szqhbc2.fsf@gnu.org> <87d1itt79z.fsf_-_@users.sourceforge.net> <7baa18d4-2b09-caa8-005e-29008a383ad1@cs.ucla.edu> <83mvhwrgd5.fsf@gnu.org> <8539f38f-9a11-44c3-4de7-bb974c96206c@cs.ucla.edu> <8360ojpndr.fsf@gnu.org> <83wpgzo30m.fsf@gnu.org> <5a4bbe6d-08ce-e6c6-39d1-49c9cd6d1ffd@cs.ucla.edu> <83mvhvns9a.fsf@gnu.org> <83d1irnozo.fsf@gnu.org> <83mvhunb0d.fsf@gnu.org> <423fab24-9be6-778c-58c3-29a0b825b8c7@cs.ucla.edu> <83a8du5gy1.fsf@gnu.org> <92ca0bf8-7ad4-a7de-70e5-ddbd6eab9741@cs.ucla.edu> <83zilt3dne.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2F8C314F6240365F9E995F07" X-Trace: blaine.gmane.org 1477328227 5803 195.159.176.226 (24 Oct 2016 16:57:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Oct 2016 16:57:07 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 24 18:57:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byiYB-0006uS-3M for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2016 18:56:39 +0200 Original-Received: from localhost ([::1]:48228 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byiYD-0003UA-CT for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2016 12:56:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byiWB-0001U6-7M for emacs-devel@gnu.org; Mon, 24 Oct 2016 12:54:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byiWA-0000K0-Dr for emacs-devel@gnu.org; Mon, 24 Oct 2016 12:54:35 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36088) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byiW5-0000G4-Av; Mon, 24 Oct 2016 12:54:29 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2297416026B; Mon, 24 Oct 2016 09:54:28 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XTuZyHmm9WI1; Mon, 24 Oct 2016 09:54:25 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 26E12160E3D; Mon, 24 Oct 2016 09:54:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rSYvJHq4TOyb; Mon, 24 Oct 2016 09:54:25 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0D4E116026B; Mon, 24 Oct 2016 09:54:25 -0700 (PDT) In-Reply-To: <83zilt3dne.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208724 Archived-At: This is a multi-part message in MIME format. --------------2F8C314F6240365F9E995F07 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/24/2016 09:39 AM, Eli Zaretskii wrote: > > Right, so I'd like your opinion and comments about the possible > solutions proposed so far: > > . Build with gmalloc but without ralloc. This goes back to what we were doing, no? > > . Back-port the HYBRID_MALLOC changes from master. Not sure if the > patch is simple and safe enough, or whether the result is tested > well enough to have that on emacs-25. This sounds riskier. > . Build with gmalloc and use mmap for buffer text allocation. This also sounds riskier. How about the attached patch for emacs-25? Basically, it says "use ralloc.c only if requested via './configure REL_ALLOC=yes'". I assume that this patch need not be ported to master, due to HYBRID_MALLOC. I haven't tested this. --------------2F8C314F6240365F9E995F07 Content-Type: text/x-patch; name="ralloc.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ralloc.diff" diff --git a/configure.ac b/configure.ac index ae7dfe5..19b44bd 100644 --- a/configure.ac +++ b/configure.ac @@ -2189,18 +2189,10 @@ if test "$doug_lea_malloc" = "yes" ; then AC_DEFINE(DOUG_LEA_MALLOC, 1, [Define to 1 if the system memory allocator is Doug Lea style, with malloc hooks and malloc_set_state.]) - - ## Use mmap directly for allocating larger buffers. - ## FIXME this comes from src/s/{gnu,gnu-linux}.h: - ## #ifdef DOUG_LEA_MALLOC; #undef REL_ALLOC; #endif - ## Does the AC_FUNC_MMAP test below make this check unnecessary? - case "$opsys" in - mingw32|gnu*) REL_ALLOC=no ;; - esac fi if test x"${REL_ALLOC}" = x; then - REL_ALLOC=${GNU_MALLOC} + REL_ALLOC=no fi use_mmap_for_buffers=no --------------2F8C314F6240365F9E995F07--