From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20687: 25.0.50; `perform-replace' should invoke a key that you have bound in `query-replace-map' Date: Tue, 2 Jun 2015 15:50:51 -0700 (PDT) Message-ID: References: <890ac68c-1c71-49c7-9e60-45afba90d74a@default> <87zj4hsr90.fsf_-_@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1433285650 14741 80.91.229.3 (2 Jun 2015 22:54:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Jun 2015 22:54:10 +0000 (UTC) Cc: 20687@debbugs.gnu.org To: Juri Linkov , Kaushal Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 03 00:53:57 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yzv2a-0005u8-Af for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jun 2015 00:52:12 +0200 Original-Received: from localhost ([::1]:32934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzv2Z-0004oA-N1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jun 2015 18:52:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzv2V-0004o2-Q5 for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2015 18:52:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzv2Q-0003VQ-Q5 for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2015 18:52:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzv2Q-0003VM-Mw for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2015 18:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yzv2P-0000hm-Tb for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2015 18:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jun 2015 22:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20687 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20687-submit@debbugs.gnu.org id=B20687.14332854632571 (code B ref 20687); Tue, 02 Jun 2015 22:52:01 +0000 Original-Received: (at 20687) by debbugs.gnu.org; 2 Jun 2015 22:51:03 +0000 Original-Received: from localhost ([127.0.0.1]:38043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yzv1R-0000fE-I8 for submit@debbugs.gnu.org; Tue, 02 Jun 2015 18:51:02 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:49639) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yzv1P-0000ev-F8 for 20687@debbugs.gnu.org; Tue, 02 Jun 2015 18:51:00 -0400 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t52Moqsh013579 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Jun 2015 22:50:53 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t52MoqWs030877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 2 Jun 2015 22:50:52 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t52MoqG0020695; Tue, 2 Jun 2015 22:50:52 GMT In-Reply-To: <87zj4hsr90.fsf_-_@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103523 Archived-At: > > + ;; Show whether `case-fold-search' is `t' or `nil' > > + (if case-fold-search "[case] " "[CaSe] ") >=20 > Maybe we should use the same message about case-folding like in > isearch? The msg should somehow indicate that what is involved here is (only) case-sensitivity wrt FROM (i.e., wrt search, not replacement). Not sure what the best way to do that would be. IOW, there is more than one use of case sensitivity here, unlike the case for search. There is what `case-fold-search' controls (the search), and there is what `case-replace' controls (the replacement). And then there is what happens for the replacement according to the case of FROM. --- BTW, we might consider binding a key to toggle case sensitivity for search as part of this bug fix (i.e., not just fixing `perform-replace' so it respects keys that user might bind). In that case, maybe the same key we use in Isearch (`M-c') would be a good choice. --- BTW2, I think that Emacs manual node `Replacement and Case' is confusing. The first three paragraphs (2/3 of the node), for instance: If the first argument of a replace command is all lower case, the command ignores case while searching for occurrences to replace--provided `case-fold-search' is non-`nil'. If `case-fold-search' is set to `nil', case is always significant in all searches. An upper-case letter anywhere in the incremental search string makes the search case-sensitive. Thus, searching for `Foo' does not find `foo' or `FOO'. This applies to regular expression search as well as to string search. The effect ceases if you delete the upper-case letter from the search string. If you set the variable `case-fold-search' to `nil', then all letters must match exactly, including case. This is a per-buffer variable; altering the variable normally affects only the current buffer, unless you change its default value. *Note Locals::. This variable applies to nonincremental searches also, including those performed by the replace commands (*note Replace::) and the minibuffer history matching commands (*note Minibuffer History::). These paragraphs really say only that the search part of replace commands acts normally: `case-fold-search' governs. They should be removed or changed to say just that. Leaving them as they are just confuses readers, = IMO.