From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56393: Actually fix the long lines display bug Date: Tue, 19 Jul 2022 14:06:17 +0000 Message-ID: References: <38c1a31040d2d2bc47ae@heytings.org> <34362AA6-6404-4727-9C60-6B6CA6736DD4@gnus.org> <83v8rvpxx7.fsf@gnu.org> <209e6aa436f84e1f729a@heytings.org> <83sfmzpw4e.fsf@gnu.org> <83h73epq7v.fsf@gnu.org> <83cze2pmtk.fsf@gnu.org> <838roqpkjs.fsf@gnu.org> <831quipdt2.fsf@gnu.org> <83r12intar.fsf@gnu.org> <83lespomnu.fsf@gnu.org> <83fsixnwh3.fsf@gnu.org> <834jzdnsxw.fsf@gnu.org> <83y1wpmciw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9242"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, larsi@gnus.org, 56393@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 19 16:10:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDnvg-0002BR-Mn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jul 2022 16:10:28 +0200 Original-Received: from localhost ([::1]:49992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDnvf-00070i-MD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jul 2022 10:10:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDnsN-0000Xv-1f for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 10:07:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57060) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDnsM-0005PV-PC for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDnsM-0008BU-By for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 10:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jul 2022 14:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56393 X-GNU-PR-Package: emacs Original-Received: via spool by 56393-submit@debbugs.gnu.org id=B56393.165823958531413 (code B ref 56393); Tue, 19 Jul 2022 14:07:02 +0000 Original-Received: (at 56393) by debbugs.gnu.org; 19 Jul 2022 14:06:25 +0000 Original-Received: from localhost ([127.0.0.1]:54819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDnrl-0008Ab-7z for submit@debbugs.gnu.org; Tue, 19 Jul 2022 10:06:25 -0400 Original-Received: from heytings.org ([95.142.160.155]:44058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDnrf-0008AO-Ch for 56393@debbugs.gnu.org; Tue, 19 Jul 2022 10:06:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1658239577; bh=9iYPYVI1bQ1oWxPfYCzdsyok78bwuyMn0q5SQuw9iLc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=sV5ta3ZugDKcqgYm95BFpWTaEzGbl3Yp+ZBXCqk0GiRKvE8tB/x2LgiO6GvrtZxcX kvHxjr/j5K0OM4ZAn18wNE+4r8oZOWozojrO6GOXfW9aexx6l1hEMQ76BFKGNEGXYX rJsoEDUmCMiKO05Jex3jfIEnxyDauh64VNrEzfrYwAIj2bczmJgbzYv1cKL0d+BWg4 3qzr/oj/aBbgtHF1AYP255fMXmEut42frYd5A42vrTSVko+ua+udW2V97sphNICVXa APO9nD7jF9ZIA6Sy8dO9KowDtHbB5zLB1tStsN38VUB3yacieIHRahCkv5SXyc68Cm ie6KofBg9DpSQ== In-Reply-To: <83y1wpmciw.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237440 Archived-At: > > Why is that a problem? For this feature, we don't need the exact number > of modifications in character units. > Again, because I want to skip the long line detection code/overhead for normal editing operation (typing one character at a time). I do not think that a 13 ms overhead for each typed character in a file with 150K lines is okay. > > Fine by me, but I think this is over-engineered. > Fine, but then you'd have to tell me how to do that in another way (that is, how to not trigger the long line detection code when the buffer has only changed a little), or to convince me that the 13 ms overhead is okay. Also note that the full changeset only has 152 insertions and 88 deletions, that is, 64 added lines. > > Also, please add a comment there explaining the heuristics, including > the cases we know about where the counters could behave "strangely" or > fail to catch changes. > I'll do that.