From: "Erik Martin-Dorel" <Erik.Martin-Dorel@irit.fr>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/opam-switch-mode 8b8670ca8b 1/3: feat(opam-switch-mode-lighter): Show the switch name in the mode-bar
Date: Wed, 12 Jul 2023 14:13:13 +0200 [thread overview]
Message-ID: <f0338-64ae9900-4f9-79856600@73633274> (raw)
In-Reply-To: <jwvsf9ut8ag.fsf-monnier+emacs@gnu.org>
Salut Stefan !
On Wednesday, July 12, 2023 00:09 CEST, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> > While `force-mode-line-update` only deals with the current buffer,
> > and `(force-mode-line-update t)` just seems to deal with all buffers from the current frame.
> > Do you confirm?
>
> No, `(force-mode-line-update t)` should apply to all frames.
OK!
> > given no subexpression of the current (opam-switch-mode-lighter)
> > involves any external system call, I'd say it is not that inefficient/costly…
>
> It's not too bad, admittedly.
>
> > https://github.com/ocaml/merlin/blob/4f6c7cfee2344dd75e9568f25c0c1576521ec049/emacs/merlin.el#L2046
> > Are you OK with that point?
>
> It's up to you.
OK ;) so, given your optimization works very well and stays simple,
I've applied it just now, and pushed a new release:
https://github.com/ProofGeneral/opam-switch-mode/compare/1.4...1.5
Thanks again,
Erik
--
Érik Martin-Dorel, PhD
Maître de Conférences, Lab. IRIT, Univ. Toulouse 3
erik.martin-dorel@irit.fr
erik.martin-dorel@master-developpement-logiciel.fr
https://www.irit.fr/~Erik.Martin-Dorel/
prev parent reply other threads:[~2023-07-12 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168910561415.26377.10324105754705665342@vcs2.savannah.gnu.org>
[not found] ` <20230711200015.24AC2C06C6C@vcs2.savannah.gnu.org>
2023-07-11 20:21 ` [nongnu] elpa/opam-switch-mode 8b8670ca8b 1/3: feat(opam-switch-mode-lighter): Show the switch name in the mode-bar Stefan Monnier
2023-07-11 21:09 ` Erik Martin-Dorel
2023-07-11 22:09 ` Stefan Monnier
2023-07-12 12:13 ` Erik Martin-Dorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0338-64ae9900-4f9-79856600@73633274 \
--to=erik.martin-dorel@irit.fr \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.