From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67462: 30.0.50; prog-fill-reindent-defun does not respect buffer-local fill-paragraph-function Date: Sun, 26 Nov 2023 23:23:04 +0200 Message-ID: References: <87zfz09q9d.fsf@sappc2.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12491"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Jens Schmidt , 67462@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 26 22:24:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r7Mbv-00030y-MD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Nov 2023 22:24:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7Mbd-0006hW-Tc; Sun, 26 Nov 2023 16:23:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7Mbc-0006hH-65 for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 16:23:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7Mbb-0005qg-UD for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 16:23:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r7Mbh-0003hQ-OT for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 16:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Nov 2023 21:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67462 X-GNU-PR-Package: emacs Original-Received: via spool by 67462-submit@debbugs.gnu.org id=B67462.170103380314170 (code B ref 67462); Sun, 26 Nov 2023 21:24:01 +0000 Original-Received: (at 67462) by debbugs.gnu.org; 26 Nov 2023 21:23:23 +0000 Original-Received: from localhost ([127.0.0.1]:42787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Mb5-0003gU-7G for submit@debbugs.gnu.org; Sun, 26 Nov 2023 16:23:23 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Mb2-0003gH-CC for 67462@debbugs.gnu.org; Sun, 26 Nov 2023 16:23:21 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DEC3F5C00BF; Sun, 26 Nov 2023 16:23:08 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 26 Nov 2023 16:23:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1701033788; x=1701120188; bh=gKdQwsVwV0swjX2E9trzcdSpq9Em1fgmDY+ Nzsm/SU8=; b=lWtONle6tIM1ReWGV1z9HKMWWU/hcxFEoCB91q7opMjPBm8OO2u VsVAYmwjtKtLqs+tGz0uC1ftgcBfrQf1FugVL0jPm6HIGdD591lgU0+50Taz9K09 f7dtdQsc8sAbdRGgkQLzvMuWPAQtSa+V5PQYnYxVEojvVH1xAno6nrzR8pfvrSp/ Bdv2qjYD/NBWmTYml4pvY147RfarRMkknkZdXMifz2d1g6gN0ovCOVC7cQs9XZH0 UomOl0gQH5cGG0GCY0jHvfR6QGDdHHgjRplzRm2cotlYOHFFXwKejLBw0m9vEKbC K1uPtokPPsx0C1I6dZMiiv4ZyQZiuFeM3aQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1701033788; x= 1701120188; bh=gKdQwsVwV0swjX2E9trzcdSpq9Em1fgmDY+Nzsm/SU8=; b=Y O1q7YoKkou6GTYvwG+kk7feXr1lcudhoZakLUw3rC7qhkvbP5y1QzCucUWhKNXDE ZASMUBYiPT+R2ewDxviunK3YJKBEm9K0gcU3Vi0JI23canEEZtmUxZeccBqBSXqA sQ2FISlpJvaBCheXPmgOtMxYY11YOgy9F4+KmbM8V2229NqWRwCOtwtRQ3UFDahH K8kgfIdz/nPpJuWGR8bzgXru63azItsMkwvCvfNlEy2Hdnvv/3rTn3LfwKQPqxmA JjqH8ZDC82AnRlKDVY/JZbtVdTZNUCqMeXZ/VTBZeRqSBEqQw9BWLYZFl0dbUKeW IItFfGZfU3rWiFYrHR6Rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehledgudehudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvfhfhjggtgfesth ejredttdefjeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehg uhhtohhvrdguvghvqeenucggtffrrghtthgvrhhnpeeghedthedujeeiteeutddtjeekhe ejteeukeehffdutdejuedvfeevueevieduudenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Nov 2023 16:23:07 -0500 (EST) Content-Language: en-US In-Reply-To: <87zfz09q9d.fsf@sappc2.fritz.box> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275088 Archived-At: On 26/11/2023 23:08, Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > diff --git a/lisp/progmodes/prog-mode.el b/lisp/progmodes/prog-mode.el > index 37c54a90f42..1bb2b678d94 100644 > --- a/lisp/progmodes/prog-mode.el > +++ b/lisp/progmodes/prog-mode.el > @@ -163,7 +163,8 @@ prog-fill-reindent-defun > (treesit-parser-list) > (treesit-node-match-p > (treesit-node-at (point)) 'text t)))) > - (if (or treesit-text-node > + (if (or (local-variable-p 'fill-paragraph-function) > + treesit-text-node > (nth 8 (syntax-ppss)) > (re-search-forward "\\s-*\\s<" (line-end-position) t)) > (fill-paragraph argument (region-active-p)) I'm not sure this is going to work well because c-mode (for example) also has a buffer-local value of fill-paragraph-function. makefile-mode does look special in this regard. Perhaps it's one of those modes that don't really use indentation in the same way as an average "prog mode" does. Maybe makefile-mode-map should simply rebind "M-q" back to 'fill-paragraph'.