From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#21804: 25.0.50; file-notify-tests failure on Cygwin Date: Thu, 29 Dec 2016 15:33:15 -0500 Message-ID: References: <563634F7.2070606@cornell.edu> <8737wpipy8.fsf@gmx.de> <87a8qv6lu2.fsf@gmx.de> <5639818A.5090307@cornell.edu> <87ziyugoqr.fsf@gmx.de> <563A3890.6030707@cornell.edu> <87si4lhaeq.fsf@gmx.de> <563ACB3F.5080709@cornell.edu> <87y4ecnrpp.fsf@gmx.de> <87r34tmv9m.fsf@gmx.de> <87h95pp6dd.fsf@gmx.de> <87zijek10s.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1483043651 23708 195.159.176.226 (29 Dec 2016 20:34:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2016 20:34:11 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 Cc: 21804@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 29 21:34:08 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMhOn-0005Rs-VS for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Dec 2016 21:34:06 +0100 Original-Received: from localhost ([::1]:37186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMhOs-00066a-Uy for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Dec 2016 15:34:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMhOn-00066K-Ji for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2016 15:34:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMhOk-00030B-H2 for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2016 15:34:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cMhOk-000302-Dc for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2016 15:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cMhOk-0005nB-7W for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2016 15:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Dec 2016 20:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21804 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21804-submit@debbugs.gnu.org id=B21804.148304359622206 (code B ref 21804); Thu, 29 Dec 2016 20:34:02 +0000 Original-Received: (at 21804) by debbugs.gnu.org; 29 Dec 2016 20:33:16 +0000 Original-Received: from localhost ([127.0.0.1]:59410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMhO0-0005m5-4D for submit@debbugs.gnu.org; Thu, 29 Dec 2016 15:33:16 -0500 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:59502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMhNy-0005ls-9n for 21804@debbugs.gnu.org; Thu, 29 Dec 2016 15:33:14 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id uBTKX8S5005532; Thu, 29 Dec 2016 15:33:08 -0500 Original-Received: from [192.168.1.9] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id uBTKX5sT014257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 29 Dec 2016 15:33:07 -0500 In-Reply-To: <87zijek10s.fsf@gmx.de> X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127560 Archived-At: Hi Michael, On 12/29/2016 2:06 PM, Michael Albinus wrote: > Ken Brown writes: > I've added the new function Fgfile_monitor_name to gfilenotify.c. It > tells us the name of the used monitor. In my case (GNU/Linux), it is > GInotifyFileMonitor. In your case it is GPollFileMonitor. Actually it turns out to be GFamFileMonitor on my system, presumably because I have the gamin package installed. I'm going to see if I can figure out how GFamFileMonitor works. As a quick check, however, I applied the following patch... --- a/test/lisp/filenotify-tests.el +++ b/test/lisp/filenotify-tests.el @@ -73,7 +73,8 @@ file-notify--test-read-event ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5. So we must ;; wait at least this time. ((and (string-equal (file-notify--test-library) "gfilenotify") - (string-equal (file-notify--test-monitor) "GPollFileMonitor")) + (or (string-equal (file-notify--test-monitor) "GPollFileMonitor") + (string-equal (file-notify--test-monitor) "GFamFileMonitor"))) 7) ((file-remote-p temporary-file-directory) 0.1) (t 0.01)))) ...and all the inexpensive tests passed. I'll keep playing with this. > PS: Could you pls provide on your site a recompiled Emacs? I would like > to use the changed gfilenotify.c. Thanks! It's building right now and should be available shortly. Best regards, Ken