From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Mon, 22 Jan 2018 09:02:47 -0800 Organization: UCLA Computer Science Department Message-ID: References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> <83bmhpt12i.fsf@gnu.org> <867escw93p.fsf@phe.ftfl.ca> <86vafwumqp.fsf@phe.ftfl.ca> <025ce2fd-a69a-12da-ce5b-c894d5636789@cs.ucla.edu> <83372zryx3.fsf@gnu.org> <4928e09c-e747-8754-973f-7b358ca3f5e7@cs.ucla.edu> <83inbtriv1.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1516640759 30174 195.159.176.226 (22 Jan 2018 17:05:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Jan 2018 17:05:59 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 Cc: jrm@ftfl.ca, ashish@FreeBSD.org, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 22 18:05:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edfXY-0007G9-J0 for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 18:05:48 +0100 Original-Received: from localhost ([::1]:53390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edfZY-0005nP-Qi for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 12:07:52 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edfUj-0002wL-Ro for emacs-devel@gnu.org; Mon, 22 Jan 2018 12:02:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edfUj-0006WP-2t for emacs-devel@gnu.org; Mon, 22 Jan 2018 12:02:53 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37704) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1edfUf-0006T4-RA; Mon, 22 Jan 2018 12:02:49 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 806BC160F9F; Mon, 22 Jan 2018 09:02:48 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Bf0CqsUBn5kf; Mon, 22 Jan 2018 09:02:47 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C6F9D161336; Mon, 22 Jan 2018 09:02:47 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JGN5Lda7R_dJ; Mon, 22 Jan 2018 09:02:47 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id ABF6B160F9F; Mon, 22 Jan 2018 09:02:47 -0800 (PST) In-Reply-To: <83inbtriv1.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222149 Archived-At: On 01/22/2018 07:52 AM, Eli Zaretskii wrote: > I didn't mean to change the API, I meant to ask why doesn't copy-file > use acl_errno_valid, and if that says the error just means ACLs aren't > supported in this case, silently gives up on copying ACLs? The return > value doesn't need to change. We use set-file-acl when we need a more > fancy copying, which we do in Lisp, so why not in the primitive? You asked why the two functions are inconsistent, and my answer was that the inconsistency springs from the fact that they have different APIs. The two functions would continue to be inconsistent even if we were to change the behavior in the way that you suggest, since set-file-acl would inform callers whether ACL setting failed (by returning nil instead of t), whereas copy-file would not. If consistency is the goal then we need to change their APIs somehow.