Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

[Dmitry Gutov]

Hi!

Bozhidar Batsov <bozhidar@batsov.com> writes:

> +(defun ruby--string-region ()
> +  "Return region for string at point."
> +  (let ((orig-point (point)) (regex "'\\(\\(\\\\'\\)\\|[^']\\)*'\\|\"\\(\\(\\\\\"\\)\\|[^\"]\\)*\"") beg end)
> +    (save-excursion
> +      (goto-char (line-beginning-position))
> +      (while (and (re-search-forward regex (line-end-position) t) (not (and beg end)))
> +        (let ((match-beg (match-beginning 0)) (match-end (match-end 0)))
> +          (when (and
> +                 (> orig-point match-beg)
> +                 (< orig-point match-end))
> +            (setq beg match-beg)
> +            (setq end match-end))))
> +      (and beg end (list beg end)))))

Any reason this doesn't do something like

(let ((state (syntax-ppss)))
  (when (memq (nth 3 state) '(?' ?\"))
    (goto-char (nth 8 state))
    (forward-sexp)
    (list (nth 8 state) (point))))

?

Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

I was thinking it might cause problems for strings that are not quoted literals. I might be wrong, though.

— 
Cheers,
Bozhidar

On December 9, 2014 at 23:47:37, Dmitry Gutov (dgutov@yandex.ru) wrote:

Hi!  

Bozhidar Batsov <bozhidar@batsov.com> writes:  

> +(defun ruby--string-region ()  
> + "Return region for string at point."  
> + (let ((orig-point (point)) (regex "'\\(\\(\\\\'\\)\\|[^']\\)*'\\|\"\\(\\(\\\\\"\\)\\|[^\"]\\)*\"") beg end)  
> + (save-excursion  
> + (goto-char (line-beginning-position))  
> + (while (and (re-search-forward regex (line-end-position) t) (not (and beg end)))  
> + (let ((match-beg (match-beginning 0)) (match-end (match-end 0)))  
> + (when (and  
> + (> orig-point match-beg)  
> + (< orig-point match-end))  
> + (setq beg match-beg)  
> + (setq end match-end))))  
> + (and beg end (list beg end)))))  

Any reason this doesn't do something like  

(let ((state (syntax-ppss)))  
(when (memq (nth 3 state) '(?' ?\"))  
(goto-char (nth 8 state))  
(forward-sexp)  
(list (nth 8 state) (point))))  

?  

[-- Attachment #2: Type: text/html, Size: 2147 bytes --]

Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

[Dmitry Gutov]

On 12/09/2014 11:50 PM, Bozhidar Batsov wrote:
> I was thinking it might cause problems for strings that are not quoted
> literals. I might be wrong, though.

What kind of problems? The suggestion does check the string's type (the 
terminating character).

IIRC, I have this kind of code somewhere else, so I'd be good to know if 
it's not ideal.

Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

The thought about using syntax-ppss crossed my mind, but I’m not particularly knowledgable there so I took a familiar route.
I’ll update the code.

P.S. Got to love cryptic code like (nth 8 state). This definitely needs a more digestible API.

-- 
Bozhidar Batsov
On December 9, 2014 at 23:47:37, Dmitry Gutov (dgutov@yandex.ru) wrote:

Hi!  

Bozhidar Batsov <bozhidar@batsov.com> writes:  

> +(defun ruby--string-region ()  
> + "Return region for string at point."  
> + (let ((orig-point (point)) (regex "'\\(\\(\\\\'\\)\\|[^']\\)*'\\|\"\\(\\(\\\\\"\\)\\|[^\"]\\)*\"") beg end)  
> + (save-excursion  
> + (goto-char (line-beginning-position))  
> + (while (and (re-search-forward regex (line-end-position) t) (not (and beg end)))  
> + (let ((match-beg (match-beginning 0)) (match-end (match-end 0)))  
> + (when (and  
> + (> orig-point match-beg)  
> + (< orig-point match-end))  
> + (setq beg match-beg)  
> + (setq end match-end))))  
> + (and beg end (list beg end)))))  

Any reason this doesn't do something like  

(let ((state (syntax-ppss)))  
(when (memq (nth 3 state) '(?' ?\"))  
(goto-char (nth 8 state))  
(forward-sexp)  
(list (nth 8 state) (point))))  

?  

[-- Attachment #2: Type: text/html, Size: 2643 bytes --]

Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

[Dmitry Gutov]

On 12/10/2014 12:07 AM, Bozhidar Batsov wrote:

> I’ll update the code.

Thanks.

> P.S. Got to love cryptic code like (nth 8 state). This definitely needs
> a more digestible API.

I don't know, I kinda like the succinctness.

Although the fact that I do have to look up the `parse-partial-sexp' 
description almost every time, says that a handful of defsubsts might 
indeed be of help.

Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

[Ted Zlatanov]

On Tue, 09 Dec 2014 17:45:09 +0000 Bozhidar Batsov <bozhidar@batsov.com> wrote: 

BB>     Add a command for string quotes toggling to ruby-mode
    
BB>     * progmodes/ruby-mode.el (ruby-toggle-string-quotes): New command that
BB>     allows you to quickly toggle between single-quoted and double-quoted
BB>     string literals.

Boshidar, this would be useful for other languages too (at least Perl
and CFEngine).  Would you be able to generalize your contribution?  If
not, would it be OK with you if I do it?

Thanks
Ted

Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

I’m fine with you generalising it, but I guess I’ll have to apply the refactoring suggested by Dmitry first.

-- 
Bozhidar Batsov
On December 10, 2014 at 04:10:48, Ted Zlatanov (tzz@lifelogs.com) wrote:

On Tue, 09 Dec 2014 17:45:09 +0000 Bozhidar Batsov <bozhidar@batsov.com> wrote:  

BB> Add a command for string quotes toggling to ruby-mode  

BB> * progmodes/ruby-mode.el (ruby-toggle-string-quotes): New command that  
BB> allows you to quickly toggle between single-quoted and double-quoted  
BB> string literals.  

Boshidar, this would be useful for other languages too (at least Perl  
and CFEngine). Would you be able to generalize your contribution? If  
not, would it be OK with you if I do it?  

Thanks  
Ted  

[-- Attachment #2: Type: text/html, Size: 1609 bytes --]

Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

[Ted Zlatanov]

On Wed, 10 Dec 2014 10:30:28 +0200 Bozhidar Batsov <bozhidar@batsov.com> wrote: 

BB> On December 10, 2014 at 04:10:48, Ted Zlatanov (tzz@lifelogs.com) wrote:

TZ> Bozhidar, this would be useful for other languages too (at least Perl  
TZ> and CFEngine). Would you be able to generalize your contribution? If  
TZ> not, would it be OK with you if I do it?  

BB> I’m fine with you generalising [`ruby-toggle-string-quotes'], but I
BB> guess I’ll have to apply the refactoring suggested by Dmitry first.

OK, let me know when you're ready with that and I'll extract it.

I am excited to use it, I've needed it several times :)

Ted

Re: master e8acfc7: Add a command for string quotes toggling to ruby-mode

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

Just committed the updated version. Looking forward to seeing this in as many modes as possible.

—
Cheers, 
Bozhidar

On December 10, 2014 at 3:25:56 PM, Ted Zlatanov (tzz@lifelogs.com) wrote:

On Wed, 10 Dec 2014 10:30:28 +0200 Bozhidar Batsov <bozhidar@batsov.com> wrote:  

BB> On December 10, 2014 at 04:10:48, Ted Zlatanov (tzz@lifelogs.com) wrote:  

TZ> Bozhidar, this would be useful for other languages too (at least Perl  
TZ> and CFEngine). Would you be able to generalize your contribution? If  
TZ> not, would it be OK with you if I do it?  

BB> I’m fine with you generalising [`ruby-toggle-string-quotes'], but I  
BB> guess I’ll have to apply the refactoring suggested by Dmitry first.  

OK, let me know when you're ready with that and I'll extract it.  

I am excited to use it, I've needed it several times :)  

Ted  



[-- Attachment #2: Type: text/html, Size: 1754 bytes --]