* bug#8361: [PATCH] Nonsense customization for debug-on-quit
@ 2011-03-28 7:35 Daniel Colascione
2011-03-28 14:31 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Colascione @ 2011-03-28 7:35 UTC (permalink / raw)
To: 8361
[-- Attachment #1.1: Type: text/plain, Size: 284 bytes --]
debug-on-quit is a simple boolean, while debug-on-error can be a list of
errors on which to break. Nevertheless, the customization definitions
for both allow users to provide a list, which is nonsense for
debug-on-quit. This patch removes the incorrect customization options.
[-- Attachment #1.2: debug-on-quit-cus.patch --]
[-- Type: text/plain, Size: 623 bytes --]
=== modified file 'lisp/cus-start.el'
--- lisp/cus-start.el 2011-03-28 06:36:08 +0000
+++ lisp/cus-start.el 2011-03-28 07:29:23 +0000
@@ -175,10 +175,7 @@
(debug-ignored-errors debug (repeat (choice symbol regexp)))
(debug-on-quit debug
(choice (const :tag "off")
- (repeat :menu-tag "When"
- :value (nil)
- (symbol :format "%v"))
- (const :tag "always" t)))
+ (const :tag "always" t)))
;; fileio.c
(delete-by-moving-to-trash auto-save boolean "23.1")
(auto-save-visited-file-name auto-save boolean)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#8361: [PATCH] Nonsense customization for debug-on-quit
2011-03-28 7:35 bug#8361: [PATCH] Nonsense customization for debug-on-quit Daniel Colascione
@ 2011-03-28 14:31 ` Stefan Monnier
2011-10-07 2:17 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2011-03-28 14:31 UTC (permalink / raw)
To: Daniel Colascione; +Cc: 8361
> debug-on-quit is a simple boolean, while debug-on-error can be a list of
> errors on which to break. Nevertheless, the customization definitions
> for both allow users to provide a list, which is nonsense for
> debug-on-quit. This patch removes the incorrect customization options.
The idea is right, but I think the code should just use the `boolean'
type rather than a `choice' between two `const's. Feel free to install
the corresponding change.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-07 2:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 7:35 bug#8361: [PATCH] Nonsense customization for debug-on-quit Daniel Colascione
2011-03-28 14:31 ` Stefan Monnier
2011-10-07 2:17 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.