From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Date: Thu, 20 Oct 2011 17:05:21 -0400 Message-ID: References: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1319144763 27199 80.91.229.12 (20 Oct 2011 21:06:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 20 Oct 2011 21:06:03 +0000 (UTC) Cc: 9781@debbugs.gnu.org To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 20 23:05:58 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RGzoK-0005Rv-LT for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Oct 2011 23:05:56 +0200 Original-Received: from localhost ([::1]:51431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGzoJ-0000nF-V0 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Oct 2011 17:05:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:45213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGzoH-0000n8-Q6 for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2011 17:05:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGzoG-0001le-BR for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2011 17:05:53 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGzoG-0001la-1Q for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2011 17:05:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RGzpO-0006lZ-23 for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2011 17:07:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Oct 2011 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9781-submit@debbugs.gnu.org id=B9781.131914479625977 (code B ref 9781); Thu, 20 Oct 2011 21:07:02 +0000 Original-Received: (at 9781) by debbugs.gnu.org; 20 Oct 2011 21:06:36 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGzox-0006kw-Nb for submit@debbugs.gnu.org; Thu, 20 Oct 2011 17:06:35 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10] ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RGzow-0006kp-2u for 9781@debbugs.gnu.org; Thu, 20 Oct 2011 17:06:35 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RGznm-0001uD-2n; Thu, 20 Oct 2011 17:05:22 -0400 X-Spook: secure Fedayeen nitrate codes sniper pink noise morse UFO X-Ran: '?8-f"0niCZ!$Blrs%kNR[MYlf}`Kp(?uqX>Y!/UO7AOy''}i^1M X-Hue: red X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 20 Oct 2011 17:07:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52953 Archived-At: Jan Dj=C3=A4rv wrote: > In a bzr repository, do > % bzr rm some-file > > and modify some other file. > > Then in Emacs, do vc-dir on the directory where the file was. > Mark the file that is listed as removed. Also mark the edited file. > Press v. > > Expected result: I can type in a log message and commit. > Real result: A prompt in the minibuffer appears: > some-file is edited but read-only; make it writable and continue? (y/n)=20 Fixed. Now you will be able to commit (and then get bug#3214). Actually the problem only happens with removed directories (because file-writable-p also returns non-nil if a file can be created). Recipe: mkdir /tmp/foo cd /tmp/foo bzr init mkdir subdir touch file subdir/subfile bzr add bzr commit -m "c1" bzr remove subdir echo 1 >> file emacs -Q M-x vc-dir RET M v > Also, the choices in the question should be three: > > 1 Make writable and continue. > 2 Don't make writable and continue > 3 Abort Isn't ctrl-g good enough for aborting, rather than introducing a 3-state question?