all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: 9781@debbugs.gnu.org
Subject: bug#9781: 24.0.90; VC can't commit removed files/directories.
Date: Thu, 20 Oct 2011 17:05:21 -0400	[thread overview]
Message-ID: <es4nz34bn2.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se>

Jan Djärv wrote:

> In a bzr repository, do
> % bzr rm some-file
>
> and modify some other file.
>
> Then in Emacs, do vc-dir on the directory where the file was.
> Mark the file that is listed as removed.  Also mark the edited file.
> Press v.
>
> Expected result: I can type in a log message and commit.
> Real result: A prompt in the minibuffer appears:
> some-file is edited but read-only; make it writable and continue? (y/n) 

Fixed. Now you will be able to commit (and then get bug#3214).

Actually the problem only happens with removed directories (because
file-writable-p also returns non-nil if a file can be created).
Recipe:

mkdir /tmp/foo
cd /tmp/foo
bzr init
mkdir subdir
touch file subdir/subfile
bzr add
bzr commit -m "c1"
bzr remove subdir
echo 1 >> file
emacs -Q
M-x vc-dir RET
M
v

> Also, the choices in the question should be three:
>
> 1 Make writable and continue.
> 2 Don't make writable and continue
> 3 Abort

Isn't ctrl-g good enough for aborting, rather than introducing a 3-state
question?






  parent reply	other threads:[~2011-10-20 21:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-18  6:36 bug#9781: 24.0.90; VC can't commit removed files/directories Jan Djärv
2011-10-18  6:59 ` Glenn Morris
2011-10-19  7:01   ` Dan Nicolaescu
2011-10-20 21:05 ` Glenn Morris [this message]
2011-10-20 21:09   ` Glenn Morris
2011-10-21  9:15     ` Jan Djärv
2011-10-29 18:32       ` Glenn Morris
2011-10-29 19:46         ` Stefan Monnier
2012-09-27  7:01           ` Glenn Morris
2011-10-21  9:13   ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=es4nz34bn2.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=9781@debbugs.gnu.org \
    --cc=jan.h.d@swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.