all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Karl Fogel <kfogel@red-bean.com>
Cc: Ivan Kanis <ivan@kanis.fr>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	Emacs Development List <emacs-devel@gnu.org>
Subject: Re: code review request for saveplace with dired buffer
Date: Fri, 07 Jun 2013 13:25:53 -0400	[thread overview]
Message-ID: <epmwr1kf32.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <8761xpvrma.fsf@kwarm.red-bean.com> (Karl Fogel's message of "Fri, 07 Jun 2013 10:59:41 -0500")

Karl Fogel wrote:

>>+  (if dired-trivial-filenames (dired-goto-next-nontrivial-file))
>>+  (if (featurep 'saveplace) (save-place-position-dired-cursor)))
>
> There might be a convention of using `when' instead of `if', when
> there's no possibility of an `else' clause.  (I'm not sure about that,
> though, so if someone else is I hope they'll speak up.)

I'm not aware of a convention. Personally I prefer (if foo) rather than
(when foo) if `foo' is a single item, but since (when foo) ==
(if (progn foo)), and the compiler optimizes away the useless progn, it
makes no difference in practice.



  reply	other threads:[~2013-06-07 17:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07  6:43 code review request for saveplace with dired buffer Ivan Kanis
2013-06-07 15:59 ` Karl Fogel
2013-06-07 17:25   ` Glenn Morris [this message]
2013-06-07 20:08     ` Drew Adams
2013-06-07 22:20       ` Karl Fogel
2013-06-08  5:09       ` Drew Adams
2013-06-07 19:12 ` Stefan Monnier
2013-06-09 15:42   ` Ivan Kanis
2013-06-09 16:20     ` Karl Fogel
2013-06-10  7:42       ` Ivan Kanis
2013-06-10 14:00         ` Karl Fogel
2013-06-10 16:35     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=epmwr1kf32.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ivan@kanis.fr \
    --cc=kfogel@red-bean.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.