From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: C++ name and add-log-current-defun Date: Wed, 27 Dec 2006 00:50:45 -0700 Message-ID: References: NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1167205882 30090 80.91.229.10 (27 Dec 2006 07:51:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 27 Dec 2006 07:51:22 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 27 08:51:20 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GzTZG-0000xS-4C for ged-emacs-devel@m.gmane.org; Wed, 27 Dec 2006 08:51:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GzTZF-0007fM-Ni for ged-emacs-devel@m.gmane.org; Wed, 27 Dec 2006 02:51:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GzTZ4-0007ep-MC for emacs-devel@gnu.org; Wed, 27 Dec 2006 02:51:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GzTZ3-0007ed-5V for emacs-devel@gnu.org; Wed, 27 Dec 2006 02:51:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GzTZ3-0007ea-2D for emacs-devel@gnu.org; Wed, 27 Dec 2006 02:51:05 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GzTZ2-0000OC-Ew for emacs-devel@gnu.org; Wed, 27 Dec 2006 02:51:04 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GzTYu-0007vl-Ec for emacs-devel@gnu.org; Wed, 27 Dec 2006 08:50:56 +0100 Original-Received: from c-24-9-156-178.hsd1.co.comcast.net ([24.9.156.178]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Dec 2006 08:50:56 +0100 Original-Received: from kevin.d.rodgers by c-24-9-156-178.hsd1.co.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Dec 2006 08:50:56 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 22 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: c-24-9-156-178.hsd1.co.comcast.net User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64325 Archived-At: Herbert Euler wrote: > Hmmm, I think the choice of ``skip-syntax-backward'' or > ``forward-sexp'' is not more important than adding a > ``while'' form; both the two functions work, but without > a ``while'' form, there is a bug. Yes, you're right. Somehow I forgot to actually check that in a C++ buffer (vs. Emacs Lisp). But I think your while condition (not (looking-back "\\(^\\| \\|\t\\)")) could be improved by specifying a LIMIT arg to looking-back (1- (point)) and/or by anchoring the regexp with \=. -- Kevin Rodgers Denver, Colorado, USA