From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#71170: 30.0.50; hs-hide-all in python mode not works as expected Date: Sun, 26 May 2024 17:31:05 +0900 Message-ID: References: <87a5kfsiuw.fsf@gmail.com> <86fru6yyly.fsf@gnu.org> <87wmnh6vbs.fsf@gmail.com> <87fru512ne.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30681"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: Eli Zaretskii , 71170@debbugs.gnu.org To: lorniu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 26 10:33:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sB9Ja-0007q9-5H for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 May 2024 10:33:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sB9JI-0008K1-Ag; Sun, 26 May 2024 04:32:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sB9JG-0008JV-GQ for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 04:32:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sB9JF-0004X8-M7 for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 04:32:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sB9JN-0008I2-LT for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 04:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2024 08:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71170 X-GNU-PR-Package: emacs Original-Received: via spool by 71170-submit@debbugs.gnu.org id=B71170.171671236531844 (code B ref 71170); Sun, 26 May 2024 08:33:01 +0000 Original-Received: (at 71170) by debbugs.gnu.org; 26 May 2024 08:32:45 +0000 Original-Received: from localhost ([127.0.0.1]:38325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB9J6-0008HX-Lw for submit@debbugs.gnu.org; Sun, 26 May 2024 04:32:44 -0400 Original-Received: from mail-pl1-f169.google.com ([209.85.214.169]:45191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB9J4-0008HK-T3 for 71170@debbugs.gnu.org; Sun, 26 May 2024 04:32:43 -0400 Original-Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1f34b5f1964so23218825ad.2 for <71170@debbugs.gnu.org>; Sun, 26 May 2024 01:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716712289; x=1717317089; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=ANi7JaZWC6McILda0KLZUrv2amHETmMDMHz/gsFw1sc=; b=TAdM37VlCjuXyGw6SqGv6uWBwZ35qyTI2alc+TAuVsDXt6seujY7zhRw36oY5DCMV/ E0xP2zcy6N8xOKZDG+pKitXZ/U/H1dgUalnUGMtftb3hx96/OJq4pO7b3I49fnt5d3ka s3Pk7nIUEbaDCSllTmWwU89ED/3zwySlinDQ/4HCOz/rMFSsVbqO7iLp5bO+N8DtgEMH gi90SIrzebsUJVYQXs1Dy2yXkust1nsh1ZNY3RT/2U+LgcNKW7OenRy5rB3VGL6sCfzf ZAzZuk/KZPojqt2luZewSPeIqXr13tdfR/ojFTqgEq4F8yP03seIm21Y3VQJdFRMPp/Q /+gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716712289; x=1717317089; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ANi7JaZWC6McILda0KLZUrv2amHETmMDMHz/gsFw1sc=; b=HL24aVqw7tX6STs6z25l14ZwOhaXPasT9zOrph/MTrFAAf0G2iv2pltfYRLjXbuXBy husekT+cIYl8I/KgwiTER9n7uocWkpB+4dCuNOfWvBLtjBEXNDMSUALAAVwsyMUbhSMr xrKIh3YazXkZpnRG/V5BTzm6o1n5lM2VI2coJESZXdGSfWogscASDaCq8kWJbqFNjN1x t3r6SOIKv0j68r4pqEo9TU34SLoGOQl8+KkZZKBILQKBewUsP1TgJza2r+Kua1lVu1aW BmSf2ilkT+Zu/hFoI9e6761RzsD+5GnP3aSp+4fJcl1oMPAZq3E7aHyJgKyY4FYy9mCJ AKpg== X-Forwarded-Encrypted: i=1; AJvYcCWcLYL59YDdpf2exFhMrlAdg5+rQ0zUc19EYS56ITFDY//Vmj7Du+5eG6Jq6y0X2fiVDM5UzW2mnFZud40aNgSMnYSgvOc= X-Gm-Message-State: AOJu0YzejalCiilEn3FeWN2W5BQpxsGSHj9CxwjzmelvkyfsfG4chCNm +7SAzeUBcxk3cgWeIK6G6Y6Jiq4o1pjImxDS/oE0J/2tYwcdCc1m X-Google-Smtp-Source: AGHT+IGsyEu1i75KFgZY/irBaLK1Vx5e6SePK6tDvFYh0jPfI0A+U7lIjbz9MrSULHea1ki2GfQy5w== X-Received: by 2002:a17:902:ea04:b0:1f4:5d87:ffb3 with SMTP id d9443c01a7336-1f45d8807d6mr52543685ad.17.1716712288932; Sun, 26 May 2024 01:31:28 -0700 (PDT) Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c759d16sm40265195ad.28.2024.05.26.01.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 01:31:28 -0700 (PDT) In-Reply-To: <87fru512ne.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285936 Archived-At: lorniu wrote: > > > > Is this what you want? > > What I want is, for example, this python code: > > ``` > if TYPE_CHECKING: > Base64FileInput = Union[IO[bytes], PathLike[str]] > FileContent = Union[IO[bytes], bytes, PathLike[str]] > else: > Base64FileInput = Union[IO[bytes], PathLike] > FileContent = Union[IO[bytes], bytes, PathLike] # PathLike is not subscriptable in Python 3.8. > > > > > class aaa: > ... > > > > class bbb: > ... > ``` > > will fold as: > > ``` > if TYPE_CHECKING:... > else:... > > class aaa:... > > class bbb:... > ``` > > instead of: > > ``` > if TYPE_CHECKING:... > else:... > > > > > class aaa:... > > > > class bbb:... > ``` > > That is too much newlines between hidden blocks. > > Maybe the patch I suggested is not well enough. Some update like this > may be better? > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > index 79e383a1c1a..009e0c4fb3a 100644 > --- a/lisp/progmodes/python.el > +++ b/lisp/progmodes/python.el > @@ -5734,7 +5734,13 @@ python-describe-at-point > (defun python-hideshow-forward-sexp-function (_arg) > "Python specific `forward-sexp' function for `hs-minor-mode'. > Argument ARG is ignored." > - (python-nav-end-of-block)) > + (python-nav-end-of-block) > + (end-of-line) > + (let ((pt (point))) > + (skip-chars-forward " \n\t") > + (re-search-backward "\n\n" pt t) > + (unless (eolp) (goto-char (1- (line-beginning-position)))) > + (when (< (point) pt) (goto-char pt)))) > > (defun python-hideshow-find-next-block (regexp maxp comments) > "Python specific `hs-find-next-block' function for `hs-minor-mode'. > > > > -- > Mess. The patch works as expected. I guess it depends on the person whether this kind of behavior is desirable or not. Wouldn't it be better to make it a customized setting or something?