From: kobarity <kobarity@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, James Thomas <jimjoe@gmx.net>
Cc: 71720@debbugs.gnu.org
Subject: bug#71720: [PATCH] Do not prematurely truncate python eldoc string
Date: Sat, 22 Jun 2024 23:16:51 +0900 [thread overview]
Message-ID: <eke7pls93vvw.wl-kobarity@gmail.com> (raw)
In-Reply-To: <86jzihgmet.fsf@gnu.org>
Eli Zaretskii wrote:
>
> > Date: Sat, 22 Jun 2024 18:14:21 +0530
> > From: James Thomas via "Bug reports for GNU Emacs,
> > the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >
> > - emacs -Q
> > - C-x C-f test.py
> > - M-x run-python
> > - C-x o
> > - Type: print(
> >
> > Only one line is shown, even with:
> >
> > - M-x eldoc-doc-buffer.
> >
> >
> > From 9fb4b45ef2c408ff76d5e145ea3c38eac60b4d16 Mon Sep 17 00:00:00 2001
> > From: James Thomas <jimjoe@gmx.net>
> > Date: Sat, 22 Jun 2024 17:57:00 +0530
> > Subject: [PATCH] Do not prematurely truncate python eldoc string
> >
> > 'eldoc-echo-area-use-multiline-p' is there for that.
> > * lisp/progmodes/python.el (python-eldoc-setup-code):
> > Make the change.
> > ---
> > lisp/progmodes/python.el | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
> > index bb2bf1731b4..a52e21f625e 100644
> > --- a/lisp/progmodes/python.el
> > +++ b/lisp/progmodes/python.el
> > @@ -5607,8 +5607,6 @@ python-eldoc-setup-code
> > doc = '{objtype} {name}{args}'.format(
> > objtype=objtype, name=name, args=args
> > )
> > - else:
> > - doc = doc.splitlines()[0]
> > except:
> > doc = ''
> > return doc"
> > --
> > 2.43.0
>
> kobarity, any comments?
I agree with this fix. For those who want the same behavior as
before, setting eldoc-echo-area-use-multiline-p to nil should be
sufficient. It might be better to make this change known in etc/NEWS,
though.
next prev parent reply other threads:[~2024-06-22 14:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 12:44 bug#71720: [PATCH] Do not prematurely truncate python eldoc string James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-22 13:03 ` Eli Zaretskii
2024-06-22 14:16 ` kobarity [this message]
2024-06-22 15:50 ` Eli Zaretskii
2024-06-22 21:12 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-23 0:47 ` kobarity
2024-06-23 3:02 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-23 3:53 ` kobarity
2024-06-27 8:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eke7pls93vvw.wl-kobarity@gmail.com \
--to=kobarity@gmail.com \
--cc=71720@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jimjoe@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.