From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#58548: 29.0.50; Invalid search bound error in python-shell-completion-at-point Date: Sat, 15 Oct 2022 22:48:37 +0900 Message-ID: Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Sat_Oct_15_22:48:37_2022-1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) To: 58548@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 15 15:50:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojhYi-0001L1-5d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 15:50:36 +0200 Original-Received: from localhost ([::1]:35888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojhYg-000727-HJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 09:50:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojhYA-00071c-Lr for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 09:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40742) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojhYA-0007V2-DL for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 09:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojhYA-0007Hc-4m for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 09:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58548 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166584174227916 (code B ref -1); Sat, 15 Oct 2022 13:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Oct 2022 13:49:02 +0000 Original-Received: from localhost ([127.0.0.1]:39820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhXB-0007Fy-K8 for submit@debbugs.gnu.org; Sat, 15 Oct 2022 09:49:02 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhX8-0007Fm-Tq for submit@debbugs.gnu.org; Sat, 15 Oct 2022 09:48:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojhX7-0006yy-CR for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 09:48:58 -0400 Original-Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:46980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojhX5-0007Ql-O9 for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 09:48:57 -0400 Original-Received: by mail-pj1-x1034.google.com with SMTP id t12-20020a17090a3b4c00b0020b04251529so7164803pjf.5 for ; Sat, 15 Oct 2022 06:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:subject:to:from:message-id:date:from:to:cc :subject:date:message-id:reply-to; bh=Boy40HmDVD97IDRpcWZu0aoi9cpXrPyfIMV5KQB+QrI=; b=jvtB6T/gWKaXIenbBh/YN+NbV2UtVHNVOQYXjgzkYMOYxJS/cAN3GXriheZ6TMIqgj 4Ex9W37dVPQJyIKWzfpcbk3h1pYS/cUO1cD143M1FCMiyr9UB/3LerY0AmSwR33jt5p0 FyDPKh4tUcp+LeBqpVVGuRMVgwD27eF1PCIaGmoaFTU09Io16lMSLzeKZ5app6kWXU9X vLiG5dUmuH2TkIcMCl3+OT7ohtGRDP2lKY9psu4Y4TrLgxeu/rW8JfjeBomqG7FITaVp xQ1mi+/1YsxnsRiqfsGdUmx8bFYcM82KDJMYLooPBTRCx+xUYZQtJvsCKKSU0WYDQQhZ 3tyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:subject:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Boy40HmDVD97IDRpcWZu0aoi9cpXrPyfIMV5KQB+QrI=; b=DVw9Id268ekJT5T5DiUSz70He0gBATqrqyfigS3az/clwsyFbYdwTcEqEJQdI06i3S gmvRekaTAWZsIdCdZEtZh8rqa+5KAa7SpFkcBm+QlhVSNOxmxSaLRoqRM32F972fZANa vOGN+JY+VG/Fqy6+EE4ODgwJ/gng3aDDWBPQ63uxKRHDzeeBtjzh6TvhhKdlY99kRSQm MdvYIlKkkky7WLMg6LZ0+TXILSKV2REAYrepVeSkY1W2N/v+DpP64GBYpTaTQPf6MNtM fIa9erAENnS6KTP9ErQBZ1W4Fb9igaDkK+LnDpTSLjbn+lY9Whi8H/vm6GTvjJuNvDom Fxkw== X-Gm-Message-State: ACrzQf18m7RThweXH6pRhoAfvD1WiwJ+Ie93jZy84wnCOcAnYwKc7hEw A5qCcaUWq6muiIHguFBapLqJggKVnTI= X-Google-Smtp-Source: AMsMyM5EY2po/uDGSxVowwjlvyF17LaF9a5PTtXoWG8inoazZ/1peATzgVd2WE+fO2Bg+/xsppk+/Q== X-Received: by 2002:a17:90b:1e0d:b0:20d:7a3b:df5b with SMTP id pg13-20020a17090b1e0d00b0020d7a3bdf5bmr3471969pjb.189.1665841733162; Sat, 15 Oct 2022 06:48:53 -0700 (PDT) Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id e14-20020a631e0e000000b0042fe1914e26sm3101902pge.37.2022.10.15.06.48.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Oct 2022 06:48:51 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=kobarity@gmail.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245555 Archived-At: --Multipart_Sat_Oct_15_22:48:37_2022-1 Content-Type: text/plain; charset=US-ASCII Hi, Attempting completion when point is before the last prompt in the Python Shell buffer causes an Invalid search bound error: 1. emacs -Q 2. M-x run-python 3. Make sure the prompt is displayed. 4. C-p (M-x previous-line) 5. TAB (M-x python-shell-completion-complete-or-indent) Attached is a patch to fix this issue. "No match" will be displayed when completion is attempted and point is before the last prompt. Best Regards, -- In GNU Emacs 29.0.50 (build 7, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2022-10-15 built on ubuntu Repository revision: a06c54209499c3885c13a8d3eba7798ab3f0d688 Repository branch: master System Description: Ubuntu 22.04.1 LTS Configured using: 'configure --without-libgmp' Configured features: ACL CAIRO FREETYPE GIF GLIB GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Python Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-hg vc-git diff-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view easy-mmode pcvs-util vc vc-dispatcher python json subr-x map project comint ansi-osc ring cl-loaddefs cl-lib ansi-color term/screen term/xterm xterm byte-opt gv bytecomp byte-compile cconv rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 66940 7163) (symbols 48 8205 0) (strings 32 23930 1490) (string-bytes 1 694497) (vectors 16 13452) (vector-slots 8 155649 7354) (floats 8 31 357) (intervals 56 229 0) (buffers 1000 12)) --Multipart_Sat_Oct_15_22:48:37_2022-1 Content-Type: application/octet-stream; type=patch; name="0001-Fix-invalid-search-bound-error-in-python-shell-compl.patch" Content-Disposition: attachment; filename="0001-Fix-invalid-search-bound-error-in-python-shell-compl.patch" Content-Transfer-Encoding: 7bit >From b0d35cdd97a2da88bc6e597d917bf87ebfe8cc64 Mon Sep 17 00:00:00 2001 From: kobarity Date: Sat, 15 Oct 2022 22:10:39 +0900 Subject: [PATCH] Fix invalid search bound error in python-shell-completion-at-point * lisp/progmodes/python.el (python-shell-completion-at-point): Add check if point is before line-start. * test/lisp/progmodes/python-tests.el (python-shell-completion-shell-buffer-1) (python-shell-completion-shell-buffer-native-1): New tests. --- lisp/progmodes/python.el | 21 ++++++++++++--------- test/lisp/progmodes/python-tests.el | 27 +++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 9 deletions(-) diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index 0de76b0bde..b81a8adeaf 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -4080,15 +4080,18 @@ python-shell-completion-at-point (buffer-substring-no-properties line-start (point))) (buffer-substring-no-properties line-start (point)))) (start - (save-excursion - (if (not (re-search-backward - (python-rx - (or whitespace open-paren close-paren string-delimiter simple-operator)) - line-start - t 1)) - line-start - (forward-char (length (match-string-no-properties 0))) - (point)))) + (if (< (point) line-start) + (point) + (save-excursion + (if (not (re-search-backward + (python-rx + (or whitespace open-paren close-paren + string-delimiter simple-operator)) + line-start + t 1)) + line-start + (forward-char (length (match-string-no-properties 0))) + (point))))) (end (point)) (prompt-boundaries (with-current-buffer (process-buffer process) diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el index 9ad2d16930..866236c977 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el @@ -4492,6 +4492,33 @@ python-shell-completion-native-with-eldoc-1 (python-eldoc-function) (should (completion-at-point))))) +(ert-deftest python-shell-completion-shell-buffer-1 () + (skip-unless (executable-find python-tests-shell-interpreter)) + (python-tests-with-temp-buffer-with-shell + "" + (python-shell-with-shell-buffer + (insert "import abc") + (comint-send-input) + (python-tests-shell-wait-for-prompt) + (insert "abc.") + (should (nth 2 (python-shell-completion-at-point))) + (end-of-line 0) + (should-not (nth 2 (python-shell-completion-at-point)))))) + +(ert-deftest python-shell-completion-shell-buffer-native-1 () + (skip-unless (executable-find python-tests-shell-interpreter)) + (python-tests-with-temp-buffer-with-shell + "" + (python-shell-completion-native-turn-on) + (python-shell-with-shell-buffer + (insert "import abc") + (comint-send-input) + (python-tests-shell-wait-for-prompt) + (insert "abc.") + (should (nth 2 (python-shell-completion-at-point))) + (end-of-line 0) + (should-not (nth 2 (python-shell-completion-at-point)))))) + ;;; PDB Track integration -- 2.34.1 --Multipart_Sat_Oct_15_22:48:37_2022-1--